From a360516e66421bc230f6dd8ae47f375664aa662a Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Mon, 21 Dec 2009 05:15:28 +0000 Subject: [PATCH] Bug #297541 - Make $(no-as-needed) trigger upstream.workaround warning. Thanks to Samuli Suominen for this patch. svn path=/main/trunk/; revision=15128 --- pym/repoman/checks.py | 8 +++++++- pym/repoman/errors.py | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index 3156894f6..4e83e6653 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -374,6 +374,12 @@ class EMakeParallelDisabledViaMAKEOPTS(LineCheck): re = re.compile(r'^\s*MAKEOPTS=(\'|")?.*-j\s*1\b') error = errors.EMAKE_PARALLEL_DISABLED_VIA_MAKEOPTS +class NoAsNeeded(LineCheck): + """Check for calls to the no-as-needed function.""" + repoman_check_name = 'upstream.workaround' + re = re.compile(r'.*\$\(no-as-needed\)') + error = errors.NO_AS_NEEDED + class DeprecatedBindnowFlags(LineCheck): """Check for calls to the deprecated bindnow-flags function.""" repoman_check_name = 'ebuild.minorsyn' @@ -468,7 +474,7 @@ _constant_checks = tuple((c() for c in ( EbuildUselessCdS, EbuildNestedDie, EbuildPatches, EbuildQuotedA, EapiDefinition, IUseUndefined, InheritAutotools, - EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, + EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, NoAsNeeded, DeprecatedBindnowFlags, SrcUnpackPatches, WantAutoDefaultValue, SrcCompileEconf, Eapi4IncompatibleFuncs, Eapi4GoneVars))) diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py index bab2faca7..b62af12b3 100644 --- a/pym/repoman/errors.py +++ b/pym/repoman/errors.py @@ -17,3 +17,4 @@ EMAKE_PARALLEL_DISABLED = 'Upstream parallel compilation bug (ebuild calls emake EMAKE_PARALLEL_DISABLED_VIA_MAKEOPTS = 'Upstream parallel compilation bug (MAKEOPTS=-j1 on line: %d)' DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d' EAPI_DEFINED_AFTER_INHERIT = 'EAPI defined after inherit on line: %d' +NO_AS_NEEDED = 'Upstream asneeded linking bug (no-as-needed on line: %d)' -- 2.26.2