From a3340fc6f44903ac778b606eac4a94955dcea241 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sat, 13 Apr 2013 07:55:50 +0100 Subject: [PATCH] Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions --- 1f/f3843afb00d8cd28e01127634cdfb06ba6b42d | 140 ++++++++++++++++++++++ 1 file changed, 140 insertions(+) create mode 100644 1f/f3843afb00d8cd28e01127634cdfb06ba6b42d diff --git a/1f/f3843afb00d8cd28e01127634cdfb06ba6b42d b/1f/f3843afb00d8cd28e01127634cdfb06ba6b42d new file mode 100644 index 000000000..fbfaeb2ad --- /dev/null +++ b/1f/f3843afb00d8cd28e01127634cdfb06ba6b42d @@ -0,0 +1,140 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4C18D431FAF + for ; Fri, 12 Apr 2013 23:55:44 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id qn-jWJJw9HSo for ; + Fri, 12 Apr 2013 23:55:43 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C1A15431FAE + for ; Fri, 12 Apr 2013 23:55:42 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1UQuN3-0002sE-C2; Sat, 13 Apr 2013 07:55:35 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1UQuN3-0004Mq-38; Sat, 13 Apr 2013 07:55:33 +0100 +From: Mark Walters +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions +In-Reply-To: <1365630175-1048-1-git-send-email-tomi.ollila@iki.fi> +References: <1365630175-1048-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 13 Apr 2013 07:55:50 +0100 +Message-ID: <87eheekjgp.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 5edd4fb3551830af940f6b21fc8b121a (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 13 Apr 2013 06:55:44 -0000 + + +On Wed, 10 Apr 2013, Tomi Ollila wrote: +> Some (declare-function ...) definitions were drifted away from the +> actual (defun ...)'s. To find the drifts and to verify changes +> the following command line was used: +> +> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")' + +This patch looks good to me +1. + +Is it worth making the above command into a test? + +Best wishes + +Mark + + +> emacs/notmuch-hello.el | 2 +- +> emacs/notmuch-show.el | 1 - +> emacs/notmuch-wash.el | 2 +- +> 3 files changed, 2 insertions(+), 3 deletions(-) +> +> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el +> index cda79f1..c1c6f4b 100644 +> --- a/emacs/notmuch-hello.el +> +++ b/emacs/notmuch-hello.el +> @@ -26,7 +26,7 @@ +> (require 'notmuch-lib) +> (require 'notmuch-mua) +> +> -(declare-function notmuch-search "notmuch" (query &optional oldest-first target-thread target-line continuation)) +> +(declare-function notmuch-search "notmuch" (&optional query oldest-first target-thread target-line continuation)) +> (declare-function notmuch-poll "notmuch" ()) +> +> (defcustom notmuch-hello-recent-searches-max 10 +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index a4d2c12..face2a0 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -38,7 +38,6 @@ +> (require 'notmuch-print) +> +> (declare-function notmuch-call-notmuch-process "notmuch" (&rest args)) +> -(declare-function notmuch-fontify-headers "notmuch" nil) +> (declare-function notmuch-search-next-thread "notmuch" nil) +> (declare-function notmuch-search-show-thread "notmuch" nil) +> +> diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el +> index 826b6f4..80c475c 100644 +> --- a/emacs/notmuch-wash.el +> +++ b/emacs/notmuch-wash.el +> @@ -23,7 +23,7 @@ +> +> (require 'coolj) +> +> -(declare-function notmuch-show-insert-bodypart "notmuch-show" (msg part depth)) +> +(declare-function notmuch-show-insert-bodypart "notmuch-show" (msg part depth &optional hide)) +> +> ;; +> +> -- +> 1.8.0 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2