From a2f7e86dda1ae8e458147d0e6424fa2795fe2a0e Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 27 Jan 2016 11:09:26 +2000 Subject: [PATCH] Re: notmuch insert --keep fails in parallel w/ notmuch new --- 4a/045bc67a85283ab96d4ae848c2854075562b8a | 62 +++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 4a/045bc67a85283ab96d4ae848c2854075562b8a diff --git a/4a/045bc67a85283ab96d4ae848c2854075562b8a b/4a/045bc67a85283ab96d4ae848c2854075562b8a new file mode 100644 index 000000000..a28539169 --- /dev/null +++ b/4a/045bc67a85283ab96d4ae848c2854075562b8a @@ -0,0 +1,62 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 3C6596DE0173 + for ; Tue, 26 Jan 2016 07:09:36 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.308 +X-Spam-Level: +X-Spam-Status: No, score=-0.308 tagged_above=-999 required=5 tests=[AWL=0.243, + RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id McxYIBmR5vw0 for ; + Tue, 26 Jan 2016 07:09:33 -0800 (PST) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id A8EAC6DE0B4F + for ; Tue, 26 Jan 2016 07:09:33 -0800 (PST) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1aO5Ef-0002TI-4g; Tue, 26 Jan 2016 10:08:49 -0500 +Received: (nullmailer pid 17863 invoked by uid 1000); + Tue, 26 Jan 2016 15:09:26 -0000 +From: David Bremner +To: Maarten Aertsen , + Notmuch Mail +Subject: Re: notmuch insert --keep fails in parallel w/ notmuch new +In-Reply-To: <20160124154800.19103.24730@kardo2.rtsn.nl> +References: <20160124154800.19103.24730@kardo2.rtsn.nl> +User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Tue, 26 Jan 2016 11:09:26 -0400 +Message-ID: <87a8nsz8bd.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 26 Jan 2016 15:09:36 -0000 + +Maarten Aertsen writes: + +> +> I had a short chat with j4ni on #notmuch, where he said: +> < j4ni> Sagi: oh bummer, we try to open the db first, and bail out +> early. we should change the order of that (at least with --keep). +> + +FWIW, I agree it's a bug, and it should be not too hard to fix by moving +the open after the call to maildir write new. + +d -- 2.26.2