From a2e7982b2abcf575040d7346437dff6fc7bd207c Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 18 Nov 2013 20:53:38 +2000 Subject: [PATCH] Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures --- 94/b5026e538a79e8585c8c5d7be23e4d9b8dbfbb | 73 +++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 94/b5026e538a79e8585c8c5d7be23e4d9b8dbfbb diff --git a/94/b5026e538a79e8585c8c5d7be23e4d9b8dbfbb b/94/b5026e538a79e8585c8c5d7be23e4d9b8dbfbb new file mode 100644 index 000000000..09c9fdb66 --- /dev/null +++ b/94/b5026e538a79e8585c8c5d7be23e4d9b8dbfbb @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8DCD1431FD4 + for ; Sun, 17 Nov 2013 16:53:53 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 1vPRKrpDxtOJ for ; + Sun, 17 Nov 2013 16:53:47 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 3ED39431FAF + for ; Sun, 17 Nov 2013 16:53:47 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1ViD5y-0004ct-RL; Sun, 17 Nov 2013 20:53:42 -0400 +Received: (nullmailer pid 16971 invoked by uid 1000); Mon, 18 Nov 2013 + 00:53:39 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 5/5] compact: provide user more information on + after-compaction failures +In-Reply-To: +References: <1384362167-12740-1-git-send-email-tomi.ollila@iki.fi> + <1384362167-12740-6-git-send-email-tomi.ollila@iki.fi> + <871u2jnkai.fsf@nikula.org> <87y54rx8sf.fsf@unb.ca> + <8738mvz2fy.fsf@zancas.localnet> + +User-Agent: Notmuch/0.16+167~g9838fe8 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 17 Nov 2013 20:53:38 -0400 +Message-ID: <87wqk6y1gt.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 18 Nov 2013 00:53:53 -0000 + +Tomi Ollila writes: +> I was thinking naming the function notmuch_database_compact_internal () +> as one option (I also though of notmuch_database_compact_unstable () -- but +> that sounds so "unstable" (at least outside Debian people ;D)) -- +> could be one option. Then developers should understand the API is not +> fixed there... + +I think 0.18 will just be an API breaking release in general; compact is +probably the least of people's worries. Yes, it's a bit more irritating +because the API will be short lived, but since we plan to change +notmuch_database_open, pretty much every client of the library will have +to update anyway. Luckily there probably aren't enough such clients to +get a really good lynch mob together. I'd suggest just mentioning it +NEWS for 0.17 that the library interface for compact is expected to +change in 0.18. + +d -- 2.26.2