From a2d4b20bc3e6a9a74c0c2926bafbd170dd101c9f Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Mon, 23 Sep 2013 20:52:57 +0100 Subject: [PATCH] [PATCH 0/2] Move pick to use prefix-arg rather than Escape --- 2d/7b9f49f4dc986f562e93f23464834e1f9212a4 | 90 +++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 2d/7b9f49f4dc986f562e93f23464834e1f9212a4 diff --git a/2d/7b9f49f4dc986f562e93f23464834e1f9212a4 b/2d/7b9f49f4dc986f562e93f23464834e1f9212a4 new file mode 100644 index 000000000..da5bfb8ff --- /dev/null +++ b/2d/7b9f49f4dc986f562e93f23464834e1f9212a4 @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id AEDCA431FB6 + for ; Mon, 23 Sep 2013 12:53:14 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.201 +X-Spam-Level: +X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id GQMvOU53pkyK for ; + Mon, 23 Sep 2013 12:53:07 -0700 (PDT) +Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com + [209.85.212.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DD5B6431FBC + for ; Mon, 23 Sep 2013 12:53:06 -0700 (PDT) +Received: by mail-wi0-f179.google.com with SMTP id hm2so2768874wib.12 + for ; Mon, 23 Sep 2013 12:53:05 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id; + bh=k4tBi+QdprUBAeK/iyoHzdVbt8z9zjY8TtdZTwR81b0=; + b=l/P3IhuWEjogjuUZ8D9hXMFqTw/7dCXtCsbt0PzAPDvYdZuey3Ve3vEvFROhqAwt0e + 7dPdar/DM7smuPwVqC/TWWRzUefg6L4PW5uSiTSa1+OSxiWrOyKkcyCQ9jOnMWuKchyS + X88Whc3fDavmS+vN+GZjhwRSHD33HoJaJTFF7BM0gHwBMfFllWq3A9sQLiLlqhS4bjlR + QCBsK0KlfKj1zRhrLG2+vsf3JPOU8b67P1i5gAra1xPFuAJOkP6ZvmZR/znmDQB1Y7Eq + G+pB01CxpVsIrwSJ/0TUv2lFuou3NPIuK07FVJ195qanIWFY14whj9l4Ww725aHZKEzA + OAzg== +X-Received: by 10.180.90.19 with SMTP id bs19mr14757202wib.15.1379965984348; + Mon, 23 Sep 2013 12:53:04 -0700 (PDT) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPSA id ey2sm720940wib.5.1969.12.31.16.00.00 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Mon, 23 Sep 2013 12:53:03 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 0/2] Move pick to use prefix-arg rather than Escape +Date: Mon, 23 Sep 2013 20:52:57 +0100 +Message-Id: <1379965979-14752-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 23 Sep 2013 19:53:14 -0000 + +To try and minimise the impact of pick on the code base some +keybindings which would naturally use a prefix argument were done as a +separate keybinding with "M-". (The reason is that a prefix argument +would have meant modifying the original function whereas the M- could +be bound to a new function in pick) + +The first patch is actually all inside pick anyway so can be +changed. The second patch removes a different occurence of the M- +keybinding temporarily: we can add back the prefix-arg version once +pick is in mainline. + +I also have some patches to add the prefix-argument (going to pick) to +hello buttons and other search entry points. (I think this is a good +reason to make the change from M- to prefix-arg as it is much easier +to link the prefix-arg into button actions). + +Best wishes + +Mark + +Mark Walters (2): + contrib: pick: move M-RET to prefix-arg RET + contrib: pick: remove temporary keybinding + + contrib/notmuch-pick/notmuch-pick.el | 52 +++++++++++++--------------------- + 1 files changed, 20 insertions(+), 32 deletions(-) + +-- +1.7.9.1 + -- 2.26.2