From a29f52bf55831e1690ded8702a3e00eb8899e912 Mon Sep 17 00:00:00 2001 From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Wed, 21 Dec 2011 14:15:00 +0100 Subject: [PATCH] Re: python: unpythonic result of Message.get_replies() --- 2b/6eb29569ce3c386c807298c0f4a8bab4028898 | 72 +++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 2b/6eb29569ce3c386c807298c0f4a8bab4028898 diff --git a/2b/6eb29569ce3c386c807298c0f4a8bab4028898 b/2b/6eb29569ce3c386c807298c0f4a8bab4028898 new file mode 100644 index 000000000..8911495bb --- /dev/null +++ b/2b/6eb29569ce3c386c807298c0f4a8bab4028898 @@ -0,0 +1,72 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id AC8D6429E28 + for ; Wed, 21 Dec 2011 05:15:17 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.001 +X-Spam-Level: +X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 + tests=[UNPARSEABLE_RELAY=0.001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id viFBzl3+RbdF for ; + Wed, 21 Dec 2011 05:15:16 -0800 (PST) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DFF1B431FB6 + for ; Wed, 21 Dec 2011 05:15:15 -0800 (PST) +Received: from mail.jade-hamburg.de (unknown [85.183.11.228]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id 9971C510345 + for ; Wed, 21 Dec 2011 14:15:14 +0100 (CET) +Received: by mail.jade-hamburg.de (Postfix, from userid 401) + id BFF97DF2A1; Wed, 21 Dec 2011 14:15:13 +0100 (CET) +Received: from thinkbox.jade-hamburg.de (unknown + [IPv6:fe80::216:d3ff:fe3e:5058%br0]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) (Authenticated sender: teythoon) + by mail.jade-hamburg.de (Postfix) with ESMTPSA id 4CE4FDF29F + for ; Wed, 21 Dec 2011 14:15:13 +0100 (CET) +Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77) + (envelope-from ) + id 1RdM0l-000330-TP + for notmuch@notmuchmail.org; Wed, 21 Dec 2011 14:15:12 +0100 +From: Justus Winter <4winter@informatik.uni-hamburg.de> +To: notmuch@notmuchmail.org +Subject: Re: python: unpythonic result of Message.get_replies() +Date: Wed, 21 Dec 2011 14:15:00 +0100 +Message-Id: + <1324473302-10869-1-git-send-email-4winter@informatik.uni-hamburg.de> +X-Mailer: git-send-email 1.7.7.3 +In-Reply-To: <87sjm79e3d.fsf@SSpaeth.de> +References: <87sjm79e3d.fsf@SSpaeth.de> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 21 Dec 2011 13:15:17 -0000 + +The attached patch series fixes this problem. Note that the wrapping +nature of the notmuch bindings makes it kind of awkward to fix the +behavior. + +I've decided to avoid introducing code to the Messages class to +indicate that there are no messages and there is no notmuch object +being wrapped, but to subclass it and change the constructor and +__next__ function. + +Well, what do you think? +Justus -- 2.26.2