From a0866d61816d73459ba43904f44f3547a9665af1 Mon Sep 17 00:00:00 2001
From: "W. Trevor King" <wking@drexel.edu>
Date: Mon, 6 Jul 2009 16:23:26 -0400
Subject: [PATCH] Avoid banded non-contact region by reducing default stepsize.

See bug 18dd6d0a-3c45-4aba-80da-fa32ffaaf5db for example banded data.
(plot deflection without lines to see why I call it "banded").  Reducing
the stepsize reduces the jolt on the cantilever, and reducing the
points-per-step accordingly means we don't have to change the
card-clock rate.  It might be worth adding "target-clock-rate" option,
and letting the stepsize be determined automatically (as an
alternative to setting the stepsize explicitly) but we'll
put that off for now...
---
 .../3447dbc0-2357-4510-805e-3e843f9c31da/body |  41 ++
 .../values                                    |   8 +
 .../a00ae6c4-0c0a-49ee-9026-c294f830ace4/body | 600 ++++++++++++++++++
 .../values                                    |  11 +
 .../values                                    |  17 +
 unfold.py                                     |   2 +-
 6 files changed, 678 insertions(+), 1 deletion(-)
 create mode 100644 .be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/3447dbc0-2357-4510-805e-3e843f9c31da/body
 create mode 100644 .be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/3447dbc0-2357-4510-805e-3e843f9c31da/values
 create mode 100644 .be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/a00ae6c4-0c0a-49ee-9026-c294f830ace4/body
 create mode 100644 .be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/a00ae6c4-0c0a-49ee-9026-c294f830ace4/values
 create mode 100644 .be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/values

diff --git a/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/3447dbc0-2357-4510-805e-3e843f9c31da/body b/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/3447dbc0-2357-4510-805e-3e843f9c31da/body
new file mode 100644
index 0000000..bc0f514
--- /dev/null
+++ b/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/3447dbc0-2357-4510-805e-3e843f9c31da/body
@@ -0,0 +1,41 @@
+For some pulling speeds and step sizes, the deflection jumps around
+after each piezo step.  This is obviously not something we want
+happening during our purportedly smooth unfolding.
+
+I've attached raw ADC data from a pull showing this effect in the next
+comment.  View (e.g. with gnuplot) by
+
+  $ be show --only-raw-body 18dd6d0a-3c45-4aba-80da-fa32ffaaf5db:2 > data
+  $ echo "plot 'data' using 1, 'data' using 2 with linespoints axis x1y2" | gnuplot -persist
+
+The parameters for that particular pull (20090523132533_unfold) are:
+  Environment
+  Time:   20090523132533
+  
+  Piezo parameters
+  Z piezo sensitivity (nm/Vp):    6.79
+  Z piezo gain (Vp/Vo):   20
+  X piezo sensitivity (nm/Vp):    34.0
+  X piezo gain (Vp/Vo):   20
+  X piezo position (nm):  134.57846952
+  
+  Approach parameters
+  Setpoint (V):   0.777676050965
+  Bind pos (nm):  -159
+  
+  Binding parameters
+  Bind time (s):  3
+  
+  Unfolding parameters
+  Distance (nm):  800
+  Step size (nm): 0.5
+  Points per step:        10
+  Unfold rate (nm/s):     718.762732761
+  Sample rate (Hz):       14375.2546552
+  
+  Data fields:    Z_piezo_out Deflection_in Z_piezo_in
+
+I thought I'd avoided this before by setting the default
+points-per-step to 1, but I must have overwritten unfold.py with
+another version.  This is why version control systems are good ;).
+
diff --git a/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/3447dbc0-2357-4510-805e-3e843f9c31da/values b/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/3447dbc0-2357-4510-805e-3e843f9c31da/values
new file mode 100644
index 0000000..2315bfe
--- /dev/null
+++ b/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/3447dbc0-2357-4510-805e-3e843f9c31da/values
@@ -0,0 +1,8 @@
+Content-type: text/plain
+
+
+Date: Mon, 06 Jul 2009 20:16:45 +0000
+
+
+From: W. Trevor King <wking@drexel.edu>
+
diff --git a/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/a00ae6c4-0c0a-49ee-9026-c294f830ace4/body b/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/a00ae6c4-0c0a-49ee-9026-c294f830ace4/body
new file mode 100644
index 0000000..4874df8
--- /dev/null
+++ b/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/a00ae6c4-0c0a-49ee-9026-c294f830ace4/body
@@ -0,0 +1,600 @@
+10427	31898	720
+10427	32010	720
+10427	31975	719
+10427	31952	719
+10427	31965	718
+10427	31973	716
+10427	31969	719
+10427	31984	718
+10427	31959	719
+10427	31994	706
+10415	31884	704
+10415	32008	708
+10415	31999	706
+10415	31956	707
+10415	31954	708
+10415	31970	706
+10415	31965	708
+10415	31962	704
+10415	31973	706
+10415	31961	692
+10403	31926	689
+10403	32003	693
+10403	31988	696
+10403	31940	694
+10403	31975	695
+10403	31987	691
+10403	31992	692
+10403	31967	696
+10403	31962	695
+10403	31962	684
+10391	31894	681
+10391	32000	682
+10391	31981	680
+10391	31950	675
+10391	31952	684
+10391	31977	682
+10391	31943	679
+10391	31953	681
+10391	31971	683
+10391	31964	668
+10379	31897	668
+10379	31993	669
+10379	32000	667
+10379	31962	662
+10379	31976	669
+10379	31981	669
+10379	31967	665
+10379	31965	665
+10379	31970	668
+10379	31962	656
+10367	31904	656
+10367	32003	653
+10367	31963	655
+10367	31974	656
+10367	31971	654
+10367	31957	655
+10367	31977	650
+10367	31962	657
+10367	31978	655
+10367	31977	639
+10355	31870	642
+10355	32013	641
+10355	31991	639
+10355	31950	636
+10355	31951	641
+10355	31963	639
+10355	31965	638
+10355	31946	639
+10355	31974	638
+10355	31959	619
+10343	31912	625
+10343	32008	624
+10343	31962	623
+10343	31942	626
+10343	31941	625
+10343	31963	627
+10343	31963	623
+10343	31945	626
+10343	31951	626
+10343	31956	610
+10331	31878	612
+10331	32017	615
+10331	31986	605
+10331	31944	613
+10331	31956	613
+10331	31980	611
+10331	31976	612
+10331	31971	613
+10331	31968	613
+10331	31963	598
+10319	31878	602
+10319	31997	598
+10319	31988	592
+10319	31954	600
+10319	31959	600
+10319	31958	596
+10319	31966	595
+10319	31940	601
+10319	31960	599
+10319	31969	589
+10307	31892	587
+10307	31993	585
+10307	31983	583
+10307	31956	584
+10307	31963	590
+10307	31991	585
+10307	31973	591
+10307	31937	589
+10307	31946	586
+10307	31972	574
+10295	31896	573
+10295	31986	573
+10295	31989	572
+10295	31964	575
+10295	31959	574
+10295	31969	574
+10295	31988	576
+10295	31958	574
+10295	31943	570
+10295	31968	562
+10283	31901	561
+10283	32016	561
+10283	31989	562
+10283	31958	560
+10283	31946	561
+10283	31974	560
+10283	31955	558
+10283	31948	558
+10283	31969	555
+10283	31955	546
+10271	31891	548
+10271	32002	546
+10271	31968	546
+10271	31956	546
+10271	31941	547
+10271	31963	546
+10271	31987	545
+10271	31950	545
+10271	31964	548
+10271	31966	536
+10259	31906	533
+10259	32023	527
+10259	31988	535
+10259	31949	535
+10259	31972	533
+10259	31970	535
+10259	31957	533
+10259	31972	535
+10259	31948	534
+10259	31943	522
+10247	31895	522
+10247	32019	520
+10247	31990	522
+10247	31958	521
+10247	31963	518
+10247	31991	521
+10247	31981	519
+10247	31960	518
+10247	31966	520
+10247	31953	510
+10235	31885	508
+10235	31989	506
+10235	31988	510
+10235	31957	509
+10235	31964	503
+10235	31996	507
+10235	31985	507
+10235	31947	507
+10235	31956	507
+10235	31965	495
+10223	31882	498
+10223	32009	496
+10223	31988	495
+10223	31936	494
+10223	31970	492
+10223	31976	495
+10223	31958	496
+10223	31955	489
+10223	31992	498
+10223	31974	485
+10211	31888	481
+10211	32015	481
+10211	31994	487
+10211	31952	483
+10211	31960	479
+10211	31961	482
+10211	31970	483
+10211	31979	481
+10211	31973	479
+10211	31973	470
+10199	31904	464
+10199	31999	471
+10199	31972	471
+10199	31952	470
+10199	31952	470
+10199	31981	470
+10199	31958	473
+10199	31979	468
+10199	31983	472
+10199	31992	457
+10187	31892	455
+10187	32020	458
+10187	31975	460
+10187	31948	454
+10187	31982	458
+10187	31980	459
+10187	31986	459
+10187	31972	457
+10187	31979	460
+10187	31966	446
+10175	31913	446
+10175	31997	445
+10175	31983	445
+10175	31971	440
+10175	31960	445
+10175	31988	447
+10175	31987	444
+10175	31969	443
+10175	31972	443
+10175	31967	431
+10163	31914	430
+10163	32026	431
+10163	31995	429
+10163	31940	428
+10163	31986	434
+10163	31979	432
+10163	31971	431
+10163	31956	433
+10163	31986	433
+10163	31975	417
+10151	31909	419
+10151	32018	420
+10151	31986	418
+10151	31962	419
+10151	31964	421
+10151	31985	420
+10151	31969	416
+10151	31970	422
+10151	31983	423
+10151	31963	406
+10139	31907	408
+10139	32027	406
+10139	31991	407
+10139	31968	406
+10139	31964	407
+10139	31976	407
+10139	31971	404
+10139	31972	405
+10139	31984	410
+10139	31969	388
+10127	31917	395
+10127	32009	392
+10127	31983	392
+10127	31965	397
+10127	31949	396
+10127	31974	392
+10127	31981	392
+10127	31973	394
+10127	31973	390
+10127	31969	377
+10115	31905	383
+10115	32005	380
+10115	32010	377
+10115	31960	383
+10115	31977	381
+10115	31998	379
+10115	31960	380
+10115	31961	381
+10115	31962	381
+10115	31992	367
+10103	31913	369
+10103	32025	369
+10103	31977	364
+10103	31976	369
+10103	31978	367
+10103	31993	363
+10103	31972	365
+10103	31984	367
+10103	31985	366
+10103	31959	354
+10091	31914	354
+10091	32018	355
+10091	31986	353
+10091	31969	353
+10091	31959	353
+10091	31986	351
+10091	31975	354
+10091	31950	355
+10091	31966	353
+10091	31982	341
+10079	31909	343
+10079	32013	341
+10079	31983	339
+10079	31967	340
+10079	31978	340
+10079	31969	340
+10079	31991	342
+10079	31977	343
+10079	31969	339
+10079	31975	331
+10067	31895	330
+10067	32016	327
+10067	31985	327
+10067	31964	330
+10067	31968	327
+10067	31958	326
+10067	31959	327
+10067	31952	328
+10067	31964	324
+10067	31977	316
+10055	31912	317
+10055	32014	312
+10055	31982	313
+10055	31962	316
+10055	31958	314
+10055	31988	315
+10055	31975	317
+10055	31945	316
+10055	31970	311
+10055	31968	301
+10043	31919	301
+10043	32010	296
+10043	31993	303
+10043	31968	300
+10043	31966	300
+10043	31993	303
+10043	31951	302
+10043	31985	301
+10043	31963	299
+10043	31995	288
+10031	31899	289
+10031	32030	287
+10031	31993	290
+10031	31988	289
+10031	31978	285
+10031	31990	287
+10031	31971	286
+10031	31976	294
+10031	31962	290
+10031	31980	276
+10019	31896	277
+10019	31991	274
+10019	32001	272
+10019	31957	274
+10019	31958	273
+10019	31985	277
+10019	31992	276
+10019	31949	273
+10019	31972	276
+10019	31976	262
+10007	31906	261
+10007	32014	262
+10007	31986	262
+10007	31964	263
+10007	31955	262
+10007	31977	263
+10007	31961	261
+10007	31991	259
+10007	31972	263
+10007	32007	249
+9995	31891	253
+9995	32016	251
+9995	31996	249
+9995	31953	247
+9995	31962	245
+9995	31989	249
+9995	31962	248
+9995	31953	246
+9995	31981	248
+9995	31953	239
+9983	31914	232
+9983	32016	236
+9983	31981	239
+9983	31952	236
+9983	31978	236
+9983	31980	239
+9983	31968	238
+9983	31988	237
+9983	31967	237
+9983	31977	226
+9971	31904	218
+9971	32009	225
+9971	32004	223
+9971	31958	221
+9971	31974	225
+9971	31989	221
+9971	31988	225
+9971	31958	222
+9971	31980	226
+9971	31993	211
+9959	31906	210
+9959	32021	210
+9959	31987	211
+9959	31960	207
+9959	31959	210
+9959	31997	209
+9959	31981	207
+9959	31969	211
+9959	31966	208
+9959	31991	197
+9947	31889	196
+9947	32021	195
+9947	31976	197
+9947	31963	196
+9947	31963	199
+9947	31988	199
+9947	31976	193
+9947	31965	197
+9947	31996	199
+9947	31970	186
+9935	31913	185
+9935	32010	185
+9935	31984	184
+9935	31970	182
+9935	31965	186
+9935	31987	186
+9935	31977	177
+9935	31967	186
+9935	31980	188
+9935	31969	171
+9923	31917	169
+9923	32003	171
+9923	31984	172
+9923	31961	171
+9923	31997	170
+9923	31987	171
+9923	31982	171
+9923	31966	171
+9923	31984	173
+9923	31997	151
+9911	31915	158
+9911	32026	160
+9911	31972	159
+9911	31958	159
+9911	31982	157
+9911	31975	158
+9911	31981	159
+9911	31960	160
+9911	31987	158
+9911	31972	145
+9899	31898	146
+9899	32000	146
+9899	32008	139
+9899	31972	146
+9899	31970	146
+9899	31994	143
+9899	31971	144
+9899	31963	148
+9899	31981	148
+9899	31970	134
+9887	31917	132
+9887	32015	130
+9887	31977	126
+9887	31981	133
+9887	31951	133
+9887	31982	130
+9887	31985	132
+9887	31980	130
+9887	31984	132
+9887	31966	117
+9875	31919	116
+9875	31999	117
+9875	31997	118
+9875	31970	118
+9875	31980	117
+9875	31967	113
+9875	31976	119
+9875	31991	117
+9875	31989	119
+9875	31987	107
+9863	31913	105
+9863	32021	106
+9863	31985	104
+9863	31975	104
+9863	31968	104
+9863	31980	105
+9863	31967	104
+9863	31977	106
+9863	31984	99
+9863	31984	90
+9851	31896	93
+9851	32040	92
+9851	31982	88
+9851	31964	90
+9851	31972	88
+9851	31987	90
+9851	31974	91
+9851	31961	92
+9851	31969	87
+9851	31989	80
+9839	31909	78
+9839	32004	73
+9839	31994	83
+9839	31963	83
+9839	31964	78
+9839	31990	80
+9839	31998	80
+9839	31946	77
+9839	31994	75
+9839	31973	67
+9827	31906	66
+9827	32028	59
+9827	32004	67
+9827	31951	65
+9827	31964	65
+9827	31985	66
+9827	31978	66
+9827	31965	65
+9827	31972	63
+9827	31984	52
+9815	31898	54
+9815	31997	54
+9815	32005	52
+9815	31948	51
+9815	31960	47
+9815	31988	54
+9815	31956	51
+9815	31965	52
+9815	31989	50
+9815	31999	41
+9803	31895	39
+9803	32003	38
+9803	31989	38
+9803	31966	38
+9803	31962	35
+9803	31986	39
+9803	31964	39
+9803	31970	37
+9803	31968	38
+9803	31983	28
+9791	31901	27
+9791	32022	26
+9791	32002	26
+9791	31949	26
+9791	31973	25
+9791	31973	27
+9791	31969	25
+9791	31975	24
+9791	31970	28
+9791	31992	15
+9779	31910	12
+9779	32014	13
+9779	31999	15
+9779	31960	13
+9779	31982	12
+9779	31995	13
+9779	31970	13
+9779	31985	11
+9779	31982	15
+9779	31983	2
+9767	31901	0
+9767	32026	0
+9767	32013	1
+9767	31969	1
+9767	31979	0
+9767	31991	0
+9767	31971	0
+9767	31971	0
+9767	31970	0
+9767	31994	0
+9755	31930	0
+9755	32027	0
+9755	31984	0
+9755	31957	0
+9755	31983	0
+9755	31985	0
+9755	31977	0
+9755	31952	0
+9755	31978	0
+9755	31970	0
+9743	31925	0
+9743	32011	0
+9743	31995	0
+9743	31963	0
+9743	31962	0
+9743	31982	0
+9743	31990	0
+9743	31991	0
+9743	31982	0
+9743	31970	0
+9731	31900	0
+9731	32027	0
+9731	31965	0
+9731	31957	0
+9731	31975	0
+9731	31992	0
+9731	31981	0
+9731	31960	0
+9731	31963	0
+9731	31979	0
+9719	31916	0
+9719	32034	0
+9719	31994	0
+9719	31966	0
+9719	31970	0
+9719	31967	0
+9719	31996	0
+9719	31987	0
+9719	31978	0
+9719	31993	0
diff --git a/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/a00ae6c4-0c0a-49ee-9026-c294f830ace4/values b/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/a00ae6c4-0c0a-49ee-9026-c294f830ace4/values
new file mode 100644
index 0000000..cc2cbeb
--- /dev/null
+++ b/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/comments/a00ae6c4-0c0a-49ee-9026-c294f830ace4/values
@@ -0,0 +1,11 @@
+Content-type: text/plain
+
+
+Date: Mon, 06 Jul 2009 20:19:40 +0000
+
+
+From: W. Trevor King <wking@drexel.edu>
+
+
+In-reply-to: 3447dbc0-2357-4510-805e-3e843f9c31da
+
diff --git a/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/values b/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/values
new file mode 100644
index 0000000..a54f63d
--- /dev/null
+++ b/.be/bugs/18dd6d0a-3c45-4aba-80da-fa32ffaaf5db/values
@@ -0,0 +1,17 @@
+creator: W. Trevor King <wking@drexel.edu>
+
+
+reporter: W. Trevor King <wking@drexel.edu>
+
+
+severity: minor
+
+
+status: closed
+
+
+summary: Banded deflection in unfolded regime
+
+
+time: Mon, 06 Jul 2009 19:17:27 +0000
+
diff --git a/unfold.py b/unfold.py
index 05fe4bd..570c9fd 100644
--- a/unfold.py
+++ b/unfold.py
@@ -107,7 +107,7 @@ class unfold :
         else: self.T = None
         self.log = unfold_data_log(dataDirectory, log_name="unfold")
     def unfold(self, setpoint=None, rel_setpoint=1.0, sBindTime = 10.0,
-               nmDist=600, nmStep=0.5, ppStep=10, nmPsRate=1000,
+               nmDist=600, nmStep=0.05, ppStep=1, nmPsRate=1000,
                dataDirectory=LOG_DIR, fileID=None) :
         while True :
             try :
-- 
2.26.2