From 9f027b25885b4d09880a03699175e5628d50ec5f Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 6 Jul 2013 11:33:52 +0300 Subject: [PATCH] Re: [PATCH 00/11] contrib: pick: keybindings --- 83/39cd8b072b779893e0f1b863c008c1ec7dceb0 | 140 ++++++++++++++++++++++ 1 file changed, 140 insertions(+) create mode 100644 83/39cd8b072b779893e0f1b863c008c1ec7dceb0 diff --git a/83/39cd8b072b779893e0f1b863c008c1ec7dceb0 b/83/39cd8b072b779893e0f1b863c008c1ec7dceb0 new file mode 100644 index 000000000..7460142f5 --- /dev/null +++ b/83/39cd8b072b779893e0f1b863c008c1ec7dceb0 @@ -0,0 +1,140 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C4998431FAF + for ; Sat, 6 Jul 2013 01:34:03 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id h2O7-K-e24Xt for ; + Sat, 6 Jul 2013 01:33:59 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 4B587431FAE + for ; Sat, 6 Jul 2013 01:33:59 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 2C4DE100051; + Sat, 6 Jul 2013 11:33:53 +0300 (EEST) +From: Tomi Ollila +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 00/11] contrib: pick: keybindings +In-Reply-To: <1373047878-20822-1-git-send-email-markwalters1009@gmail.com> +References: <1373047878-20822-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.15.2+193~g7350bd4 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 06 Jul 2013 08:34:03 -0000 + +On Fri, Jul 05 2013, Mark Walters wrote: + +> This series adds lots of keybindings and funtionality to pick: in +> particular it adds the stash keymap, the ability to tab between and +> activate buttons in the message pane, and it reduces a lot of code +> duplication between pick and show. +> +> It is a large series: but most of it is a lot of small changes. These +> small changes are mostly logically independent but as they add +> keybindings their contexts all clash. I have made most of the +> keybindings as single separate patches to make discussion of them +> individually easier. +> +> The key patches for review/discussion (apart from bike-shedding on +> key-bindings!) are patches 1, 5 and 8. + +Now that you "asked", I'd ask what was used as a reason to decide "/" +as keybinding for notmuch-pick-button-activate -- something common +or as a convenience. In US/UK keyboard "/" is left to Right Shift, +but for example in my keyboard it is Shift-7... + +> Patch 1 is the most "controversial": it over-rides +> notmuch-show-get-prop so that whether it uses +> notmuch-show-get-message-properties or +> notmuch-pick-get-message-properties depends on the major-mode (ie +> whether it is called from pick or show). + +At the moment the code comments could have something like XXX to +emphasize the situation. IMHO it is ok to have this in contrib +code -- when this is going to be "official" part of emacs MUA +then this code needs to be ... well, at least moved to other place :D + +Apart from these code LGTM. + +Tomi + + +> This means that functions from show which just use message properties +> (most often just the message id) "just work" when called from pick. In +> particular it gives us access to lots of functions without having to +> duplicate the code. +> +> In the longer term it would be better to have some show/pick common +> file and migrate the common functions there. +> +> Patch 5 and 8 add in functions for creating fucntions ready to be used +> in keybindings. The one in patch 5 takes a show fucntion and creates a +> function which switches from pick to the message pane, applies the +> function and then switches back to pick. The one in patch 8 takes a +> function and creates a function which closes the message pane and the +> calls this function. +> +> Both of these make the keybinding section clearer. They also have the +> advantage that the user can use them easily to create their own +> keybindings which do this. +> +> This completes all the keybindings I use and I think means that pick +> doesn't have any glaring omissions. +> +> Finally, this will clash with the thread archive patches +> id:1371195472-441-1-git-send-email-markwalters1009@gmail.com +> +> Best wishes +> +> Mark +> +> Mark Walters (11): +> contrib: pick: override notmuch-show-get-prop +> contrib: pick: Link in notmuch-show-pipe-message +> contrib: pick: Link in attachment functions straight from +> notmuch-show +> contrib: pick: Link in stash map straight from notmuch-show +> contrib: pick: add in to-message-window function +> contrib: pick: add button press helper +> contrib: pick: pass tab through to the message pane +> contrib: pick: close window function +> contrib: pick: make help close the message pane first +> contrib: pick: add in binding to view raw message +> contrib: pick: use close-message-pane for reply etc +> +> contrib/notmuch-pick/notmuch-pick.el | 139 +++++++++++++++++----------------- +> 1 files changed, 70 insertions(+), 69 deletions(-) +> +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2