From 9dec1517a4c4162ee1935591ba46e32f3c63e03b Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Thu, 15 Aug 2013 13:20:36 +2000 Subject: [PATCH] Re: [PATCH 0/6] Clean up reply's encoding story --- 0e/488ed40b67318682bfc9d2b06b1a59aee37faf | 112 ++++++++++++++++++++++ 1 file changed, 112 insertions(+) create mode 100644 0e/488ed40b67318682bfc9d2b06b1a59aee37faf diff --git a/0e/488ed40b67318682bfc9d2b06b1a59aee37faf b/0e/488ed40b67318682bfc9d2b06b1a59aee37faf new file mode 100644 index 000000000..ebb28bc17 --- /dev/null +++ b/0e/488ed40b67318682bfc9d2b06b1a59aee37faf @@ -0,0 +1,112 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 26DF8431FD4 + for ; Wed, 14 Aug 2013 10:20:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Y0IfAealPF6L for ; + Wed, 14 Aug 2013 10:20:42 -0700 (PDT) +Received: from dmz-mailsec-scanner-3.mit.edu (dmz-mailsec-scanner-3.mit.edu + [18.9.25.14]) + by olra.theworths.org (Postfix) with ESMTP id 94E98431FC0 + for ; Wed, 14 Aug 2013 10:20:42 -0700 (PDT) +X-AuditID: 1209190e-b7f988e0000009a7-1e-520bbc696eab +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP + id FA.EE.02471.96CBB025; Wed, 14 Aug 2013 13:20:41 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id r7EHKdEJ003180; + Wed, 14 Aug 2013 13:20:40 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r7EHKb03012335 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Wed, 14 Aug 2013 13:20:38 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1V9ekO-0005PA-Vz; Wed, 14 Aug 2013 13:20:37 -0400 +Date: Wed, 14 Aug 2013 13:20:36 -0400 +From: Austin Clements +To: Tomi Ollila +Subject: Re: [PATCH 0/6] Clean up reply's encoding story +Message-ID: <20130814172036.GF13257@mit.edu> +References: <1376332839-22825-1-git-send-email-amdragon@mit.edu> + +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hRV1s3cwx1kMGOTsMX1mzOZLd6snMfq + wORx+OtCFo9nq24xBzBFcdmkpOZklqUW6dslcGX82WJY8JKvYkbDL8YGxvfcXYycHBICJhLN + dw6wQthiEhfurWfrYuTiEBLYxyhxs/02K4SzkVHi8pZXzBDOaSaJuy2nwFqEBJYwSqxoVAGx + WQRUJRpWvWUHsdkENCS27V/OCGKLCKhIPGhbD1bPLCAt8e13MxOILSxgIdF54gJYnFdAR2LV + p28sEDPTJD4f7WKHiAtKnJz5hAWiV0vixr+XQL0cYHOW/+MACXMKGEgcv7eTGcQWBVo15eQ2 + tgmMQrOQdM9C0j0LoXsBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXWO93MwSvdSU0k2M4KCW + 5NvB+PWg0iFGAQ5GJR7eiDbuICHWxLLiytxDjJIcTEqivP7bgUJ8SfkplRmJxRnxRaU5qcWH + GCU4mJVEeM90AOV4UxIrq1KL8mFS0hwsSuK8z56eDRQSSE8sSc1OTS1ILYLJynBwKEnwhu4G + ahQsSk1PrUjLzClBSDNxcIIM5wEavmoXyPDigsTc4sx0iPwpRkUpcV41kGYBkERGaR5cLyzp + vGIUB3pFmDcJpIoHmLDgul8BDWYCGuyQzQUyuCQRISXVwNgy+9M2kUp5h2sqcWz8r83Xb7Rj + Um79NOfkx0hOq27NoiXmZ54efKBba/z7u0vereScaxfPXVWYqq0aPiGr58T/nJNumUoyL8ya + bwnHH/r0M+PLg60/77gx+E2VLtodYSKrFu33O2feeua9spnZXwvXXhRfb3P7zlXnB8F2klVq + kq7KC2q1XiuxFGckGmoxFxUnAgB7JuoqFQMAAA== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 14 Aug 2013 17:20:48 -0000 + +Quoth Tomi Ollila on Aug 14 at 8:04 pm: +> On Mon, Aug 12 2013, Austin Clements wrote: +> +> > Jeff Stedfast's email about gmime-filter-headers.c possibly being +> > unnecessary with GMime 2.6 (quoted in id:87bo56viyo.fsf@nikula.org) +> > sent me on a wild goose chase that led to this patch series. It +> > turned out that we *did* need gmime-filter-headers for what we were +> > doing in the reply text format, but what we were doing made no sense. +> > Patches 1 through 4 are simply the documentation and tests that I left +> > in my wake and are harmless to push. Patch 6 is my conclusion that +> > how we were handling header encoding in the text reply format made no +> > sense. Patch 5 is a step toward patch 6, but makes sense on its own +> > even if we decide against patch 6. +> +> The whole series Looks Good To Me (sans known hiccups). I tested the patch 6 +> affecting 'default' output of notmuch reply bot not json or sexp output +> (which I found surprising as so much code was removed). All the explations +> in id:1376332839-22825-7-git-send-email-amdragon@mit.edu makes good sense +> (but fix also 'tmeplate'). +> +> A slighly related note: ^M:s ^J:s (among other chars) don't get encoded +> into =?utf-8?b?...?= ... + +Do you mean when sending mail, or when replying to a message with +encoded ^Ms and ^Js? + +> ... also interestingly if U+202E (LEFT-TO-RIGHT OVERRIDE) is in (at least +> From) header it disappears from `notmuch reply` default format. In json +> and sexp format it disappears in 'reply-headers' but exists in 'headers'. +> emacs client seems to use reply-headers as none of the header text lines +> in buffer is rendered RTL. + +Cool. My guess would be that one of these it coming from notmuch's +internal header parser (via notmuch_message_get_header) and the other +is coming from GMime's header parser (used in notmuch-show.c) -- 2.26.2