From 9cc534ef70a8ff743efc6168752e934589efec34 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sat, 11 May 2013 21:15:41 +0100 Subject: [PATCH] [PATCH 0/3] Allow widen reply --- 8b/7bbb9fc438ab0e4f11f1456b0f02af3c037fa8 | 105 ++++++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 8b/7bbb9fc438ab0e4f11f1456b0f02af3c037fa8 diff --git a/8b/7bbb9fc438ab0e4f11f1456b0f02af3c037fa8 b/8b/7bbb9fc438ab0e4f11f1456b0f02af3c037fa8 new file mode 100644 index 000000000..2d1cdbea8 --- /dev/null +++ b/8b/7bbb9fc438ab0e4f11f1456b0f02af3c037fa8 @@ -0,0 +1,105 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1B1CD431FBF + for ; Sat, 11 May 2013 13:15:56 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.201 +X-Spam-Level: +X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id IEN7ajoVR39E for ; + Sat, 11 May 2013 13:15:50 -0700 (PDT) +Received: from mail-we0-f181.google.com (mail-we0-f181.google.com + [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 71F72431FAE + for ; Sat, 11 May 2013 13:15:50 -0700 (PDT) +Received: by mail-we0-f181.google.com with SMTP id q55so5058010wes.40 + for ; Sat, 11 May 2013 13:15:49 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=x-received:from:to:cc:subject:date:message-id:x-mailer; + bh=ey0ldko4x5ZzK+J3RtTlVGC8Ygr+9mOA5ms8fSm2XPQ=; + b=M2PDih4xHtu7LWnetYR1Xnmc8ps5ux2ROIXgYLNJb9AYwOTlX00tPu0PpAD5n6zG0o + QG0jsusNn5KrH1fp08ehHd2T0mcvfCqy/Nbdmpao+zMKW8CBxjnctPL4d3XVZDh9oEPc + Q0RWZOKe9cQuMsL3OMW9ULGQT4NNyNfhc/pjXe2I/i+mCBrSwAJvkKBDa4HP84IuDRxb + YXIw5VoM9Dw67cfOTH5eeoh4JBs34Jn4yiZQQ9HDoWRfU3jiHS7RvnD/BhlKwZD5ZxHW + WtX11qGz3BTv/pNcHCsLpOZ5xE4yutH3GmU1lbDO6wOwlGn4CB9oMlmXSh2Zthzq2N0z + 1Lqg== +X-Received: by 10.180.185.207 with SMTP id fe15mr10262458wic.33.1368303349369; + Sat, 11 May 2013 13:15:49 -0700 (PDT) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPSA id ek7sm5801316wic.4.2013.05.11.13.15.48 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sat, 11 May 2013 13:15:48 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 0/3] Allow widen reply +Date: Sat, 11 May 2013 21:15:41 +0100 +Message-Id: <1368303344-13713-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 11 May 2013 20:15:56 -0000 + +This is an initial draft of a patch to allow the emacs frontend to +"widen" the reply: i.e., change the headers to reply-to-all after a +reply-to-sender has been started. + +The reply cli json output is modified to always output the +reply-to-all headers. + +Emacs message mode already as a key binding for widening reply (C-c +C-f w) so we use that. + +There are some things that need to be worked out: do we want to allow +narrowing the reply (ie going from reply-to-all back to +reply-to-sender)? I did not implement this as it was slightly easier +not to, message-mode doesn't have this by default, and it's easy for a +user to remove recipients. + +I have not updated tests (the reply json test fails) or the +schemata. I thought it was worth deciding what format we wanted for +the json first. + +Finally, I am not sure I have got the overriding of +message-widen-reply keybinding right. It does seem to work. + +Best wishes + +Mark + + + +Mark Walters (3): + cli: show: separate out the printing of recipient headers + cli: reply: additionally output reply-to-all headers to allow widen + reply + emacs: mua: allow the user to widen the reply + + emacs/notmuch-mua.el | 22 +++++++++++++++++++++- + notmuch-client.h | 3 +++ + notmuch-reply.c | 18 +++++++++++++++++- + notmuch-show.c | 35 +++++++++++++++++++++-------------- + 4 files changed, 62 insertions(+), 16 deletions(-) + +-- +1.7.9.1 + -- 2.26.2