From 9bc96b257053fa1711b48739e4bbe879c4dea7e0 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 12 Nov 2013 09:42:45 +2000 Subject: [PATCH] Re: fix for failing tests with gmime 2.6.19 --- 8a/6484b76826ce3b1059705ff7636e4c2218d97b | 88 +++++++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 8a/6484b76826ce3b1059705ff7636e4c2218d97b diff --git a/8a/6484b76826ce3b1059705ff7636e4c2218d97b b/8a/6484b76826ce3b1059705ff7636e4c2218d97b new file mode 100644 index 000000000..f54882a81 --- /dev/null +++ b/8a/6484b76826ce3b1059705ff7636e4c2218d97b @@ -0,0 +1,88 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1C81F431FAF + for ; Mon, 11 Nov 2013 05:43:04 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id lADrb4y2VcdS for ; + Mon, 11 Nov 2013 05:42:56 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 905C2431FAE + for ; Mon, 11 Nov 2013 05:42:56 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1VfrlV-0000oC-5q; Mon, 11 Nov 2013 09:42:53 -0400 +Received: (nullmailer pid 30213 invoked by uid 1000); Mon, 11 Nov 2013 + 13:42:45 -0000 +From: David Bremner +To: Daniel Kahn Gillmor , notmuch + +Subject: Re: fix for failing tests with gmime 2.6.19 +In-Reply-To: <87iovzywua.fsf@zancas.localnet> +References: <1384100482-15453-1-git-send-email-david@tethera.net> + <52805350.70004@fifthhorseman.net> <87iovzywua.fsf@zancas.localnet> +User-Agent: Notmuch/0.16+161~gd941536 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 11 Nov 2013 09:42:45 -0400 +Message-ID: <87iovzvyui.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 11 Nov 2013 13:43:04 -0000 + +David Bremner writes: + +> Daniel Kahn Gillmor writes: +> +>> +>> Please don't introduce this cruft into the notmuch codebase. It should +>> be fixed in gmime, not worked-around notmuch. +>> +>> I've just uploaded gmime 2.6.19-2 to unstable to address this issue. +>> +> +> Hi Daniel; +> +> Thanks a lot for that. +> +> What I (still) wonder about is all the people not running Debian, in the +> interval between the release of notmuch 0.17 and the next upstream +> release of gmime (and propagation to various distros). Even on Debian, +> building on testing and backports complicates things a bit. + +An alternative approach would be to fix + + NOTMUCH_SKIP_TESTS="reply reply-to-sender multipart.37 from-guessing" ./notmuch-test + +to return exist status 0, and ideally to print the correct number of +tests skipped. + +I think the former just requires patching line 85 of +aggregate-results.sh. I don't see an easy way to do the latter. + +This is arguably less crufty, or at least uses existing cruft. On the +other hand, it doesn't distinguish between a test printing an extra +space, and complete garbage. + +d -- 2.26.2