From 9a86337c6bbbd84935e7bedf6c3d99eb4a763fca Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sat, 14 Jun 2014 22:47:56 +2100 Subject: [PATCH] Re: [PATCH] configure: add workaround for systems without zlib.pc --- 15/ec7ed831a3ee6cba2d84b75a55cab578a811cb | 85 +++++++++++++++++++++++ 1 file changed, 85 insertions(+) create mode 100644 15/ec7ed831a3ee6cba2d84b75a55cab578a811cb diff --git a/15/ec7ed831a3ee6cba2d84b75a55cab578a811cb b/15/ec7ed831a3ee6cba2d84b75a55cab578a811cb new file mode 100644 index 000000000..ea92b9f73 --- /dev/null +++ b/15/ec7ed831a3ee6cba2d84b75a55cab578a811cb @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 165FF431FBC + for ; Fri, 13 Jun 2014 18:48:16 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 88M40-s7NvO7 for ; + Fri, 13 Jun 2014 18:48:06 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id AB0A1431FAF + for ; Fri, 13 Jun 2014 18:48:06 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1Wvd4a-0002qE-7M; Fri, 13 Jun 2014 22:48:00 -0300 +Received: (nullmailer pid 1968 invoked by uid 1000); Sat, 14 Jun 2014 + 01:47:56 -0000 +From: David Bremner +To: Tomi Ollila , Felipe Contreras + , notmuch@notmuchmail.org +Subject: Re: [PATCH] configure: add workaround for systems without zlib.pc +In-Reply-To: +References: <1399864172-28227-1-git-send-email-felipe.contreras@gmail.com> + +User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 13 Jun 2014 22:47:56 -0300 +Message-ID: <87ha3o5kj7.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 14 Jun 2014 01:48:16 -0000 + +Tomi Ollila writes: + +>> +static const char *template = +>> + "prefix=/usr\n" +>> + "exec_prefix=${prefix}\n" +>> + "libdir=${exec_prefix}/lib\n" +>> + "\n" +>> + "Name: zlib\n" +>> + "Description: zlib compression library\n" +>> + "Version: %s\n" +>> + "Libs: -lz\n"; +> +> The above is bit different what zlib.pc files have in e.g. Fedora 20 and +> Ubuntu 14.04 machines: those have 'Requires: before Libs: (and Cflags:)' +> But probably that is unnecessary (and just some sugar coating...?). +> + +it seems consistent with the 'foo' example at + + http://people.freedesktop.org/~dbn/pkg-config-guide.html#writing + +> +> To be consistent what we do elsewhere: +> +> PKG_CONFIG_PATH=${PKG_CONFIG_PATH:+$PKG_CONFIG_PATH:}compat && +> +> i.e. don't add ':' in case $PKG_CONFIG_PATH is not defined or is empty string. + +What Tomi writes here sounds correct to me. I guess empty PKG_CONFIG_PATH is +probably the most common case. + +d -- 2.26.2