From 991255c634500fe51a70aae6a8e7c8d7b73db0cc Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 31 Aug 2008 19:45:07 -0700 Subject: [PATCH] git-svn: check error code of send_txstream Not checking the error code of a function used to transform and send data makes me nervous. It currently returns "undef" on success; so die if we get any result other than "undef" because it's likely something went wrong somewhere. I really wish this function returned an MD5 like send_stream (or better yet, SHA1) for verification. Signed-off-by: Eric Wong --- git-svn.perl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/git-svn.perl b/git-svn.perl index fdf4e4a45..2d355c183 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -3697,7 +3697,11 @@ sub chg_file { my $atd = $self->apply_textdelta($fbat, $exp_a, $pool); if (-s $fh_a) { my $txstream = SVN::TxDelta::new ($fh_a, $fh_b, $pool); - SVN::TxDelta::send_txstream($txstream, @$atd, $pool); + my $res = SVN::TxDelta::send_txstream($txstream, @$atd, $pool); + if (defined $res) { + die "Unexpected result from send_txstream: $res\n", + "(SVN::Core::VERSION: $SVN::Core::VERSION)\n"; + } } else { my $got = SVN::TxDelta::send_stream($fh_b, @$atd, $pool); die "Checksum mismatch\nexpected: $exp_b\ngot: $got\n" -- 2.26.2