From 9889b4cc9758ba619805c24b9ecdeeef3ef39146 Mon Sep 17 00:00:00 2001 From: Thomas Jost Date: Tue, 11 Oct 2011 21:49:48 +0200 Subject: [PATCH] Re: [PATCH 2/4] emacs: Support a message-mode switch function in notmuch-mua --- e6/234db67f084024adc844837bfbe868e0445105 | 116 ++++++++++++++++++++++ 1 file changed, 116 insertions(+) create mode 100644 e6/234db67f084024adc844837bfbe868e0445105 diff --git a/e6/234db67f084024adc844837bfbe868e0445105 b/e6/234db67f084024adc844837bfbe868e0445105 new file mode 100644 index 000000000..75118a34e --- /dev/null +++ b/e6/234db67f084024adc844837bfbe868e0445105 @@ -0,0 +1,116 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5CA5F429E25 + for ; Tue, 11 Oct 2011 12:49:54 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.1 +X-Spam-Level: +X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 73oth+Igehjf for ; + Tue, 11 Oct 2011 12:49:53 -0700 (PDT) +Received: from ks3536.kimsufi.com (schnouki.net [87.98.217.222]) + by olra.theworths.org (Postfix) with ESMTP id 9FE1D431FB6 + for ; Tue, 11 Oct 2011 12:49:53 -0700 (PDT) +Received: from odin.local (nancy.schnouki.net [78.238.0.45]) + by ks3536.kimsufi.com (Postfix) with ESMTPSA id 05B446A06A9; + Tue, 11 Oct 2011 21:49:51 +0200 (CEST) +DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=schnouki.net; + s=key-schnouki; t=1318362592; + bh=zq5orsiAhxMB6MtiWKqndVl7tNSiN8/wkNEXRL07+oo=; + h=From:To:Subject:In-Reply-To:References:Date:Message-ID: + MIME-Version:Content-Type; + b=fc1w7mAIhwlstYtPVyLg3HfsE07McFpqC0l5hratzFi7htHpI4GqraLIa2D/ehb8c + UYUQYaOQYZrlqvUURvt3HSLea7IByRbuGrUx1VHWYjZpJBlrNyjbLfUCC6IgPXO58h + kj/yJ5hvv1pTqTpvrZdmkyooWwycTO53vic5DRpw= +From: Thomas Jost +To: Jameson Graef Rollins , + notmuch@notmuchmail.org +Subject: Re: [PATCH 2/4] emacs: Support a message-mode switch function in + notmuch-mua +In-Reply-To: <877h4cc0bn.fsf@washington.ligo-wa.caltech.edu> +References: <1317643438-31272-1-git-send-email-schnouki@schnouki.net> + <1317643438-31272-3-git-send-email-schnouki@schnouki.net> + <877h4cc0bn.fsf@washington.ligo-wa.caltech.edu> +User-Agent: Notmuch/0.9_rc1-74-gdae3084 (http://notmuchmail.org) + Emacs/24.0.90.1 (x86_64-unknown-linux-gnu) +Date: Tue, 11 Oct 2011 21:49:48 +0200 +Message-ID: <8739eztijn.fsf@schnouki.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 11 Oct 2011 19:49:54 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Mon, 10 Oct 2011 08:50:52 -0700, Jameson Graef Rollins wrote: +> However, I find the customization variable a bit clunky. Since I wasn't +> presented with any options in the customization, I didn't know what to +> put in. I copy and pasted "switch-to-buffer-other-frame" into the +> customization field but that didn't work since I didn't protect the +> function name. Finally I got it to work by putting in +> "'switch-to-buffer-other-frame" (with the initial "'"). +>=20 +> So I definitely love this feature, but can we make the customization +> work better so that it's easier for the user to figure out how to set +> it? + +Heh, I had just tested it using "(setq ...)", not using M-x customize. +And yes, when using the customization interface it's not clear at all. +The problem is that the ":options" property of customizable variables +is only useful for hooks or alists, not for functions (but that isn't +documented anywhere, I had to dig in custom.el to find this). + +So I think the best way to make that clearer and easier to figure out is +just to add more details in the docstring. I'll send a patch as a reply +to this message. + +> Another question about this feature: how do you make the window +> (frame) go away after the email is sent? + +I do this: + (add-hook 'message-sent-hook 'delete-frame) + +(added to the doc too). + +Thanks for your review :) + +=2D-=20 +Thomas/Schnouki + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iQEcBAEBAgAGBQJOlJ3cAAoJEMPdciX+bh5IbUEH/iggjhul3tdzFHvzl3zfoVYt +E5TBrG5jzHCMSG7W1ar3Y0Lqf2W51ftN6dDc7ovfn5cEAcu1GXO+rB03AdwAqAQh +u69RAc5Ke5N7Uy8v3jPXMfzEmZ+iePzzZ9mp79lMF3naKQWUdbZBnTZWk5qn6hcD +Kj3xCNltsk70Y96AG9HSJbPklwdPfNmnwd4v3aZW7Q9Hi4xQm0A7YfyM07JJVMqo +qNrYPKfH0EwnbAk50N1L4CvuWTJzi6Cqgs8FnSDV5Zsxem9sNQcWIigU302uDFEj +2TlXxJNxodX31aOzzcGGXOROmw3C9mZfgGHila+VW6y8EEp+l9z1hevovq02Fv4= +=Svcj +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2