From 981a7a9958c658122fba99d13c07100431f5d5fb Mon Sep 17 00:00:00 2001 From: Peter Zijlstra Date: Sun, 12 Jan 2014 17:06:19 +0100 Subject: [PATCH] Re: [PATCH] notmuch: Add "maildir:" search option --- e3/e32c8f258e92217b1bde2aac1cec49afbe44d3 | 90 +++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 e3/e32c8f258e92217b1bde2aac1cec49afbe44d3 diff --git a/e3/e32c8f258e92217b1bde2aac1cec49afbe44d3 b/e3/e32c8f258e92217b1bde2aac1cec49afbe44d3 new file mode 100644 index 000000000..4594d1a5a --- /dev/null +++ b/e3/e32c8f258e92217b1bde2aac1cec49afbe44d3 @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 166F0431E84 + for ; Sun, 12 Jan 2014 08:06:31 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fOW3e2nyM2CO for ; + Sun, 12 Jan 2014 08:06:23 -0800 (PST) +Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 36CF1431E82 + for ; Sun, 12 Jan 2014 08:06:23 -0800 (PST) +Received: from dhcp-077-248-225-117.chello.nl ([77.248.225.117] helo=laptop) + by merlin.infradead.org with esmtpsa (Exim 4.80.1 #2 (Red Hat Linux)) + id 1W2NYL-0002pl-UH; Sun, 12 Jan 2014 16:06:22 +0000 +Received: by laptop (Postfix, from userid 1000) + id BE02110806051; Sun, 12 Jan 2014 17:06:19 +0100 (CET) +Date: Sun, 12 Jan 2014 17:06:19 +0100 +From: Peter Zijlstra +To: Jani Nikula +Subject: Re: [PATCH] notmuch: Add "maildir:" search option +Message-ID: <20140112160619.GM7572@laptop.programming.kicks-ass.net> +References: <20131112155637.GA16796@laptop.programming.kicks-ass.net> + <8761ppurfz.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <8761ppurfz.fsf@nikula.org> +User-Agent: Mutt/1.5.21 (2012-12-30) +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 12 Jan 2014 16:06:31 -0000 + +On Sun, Jan 12, 2014 at 05:53:52PM +0200, Jani Nikula wrote: +> On Tue, 12 Nov 2013, Peter Zijlstra wrote: +> > Subject: notmuch: Add "maildir:" search option +> > +> > The current "folder:" search terms are near useless when you have +> > recursive folders, introduce a boolean "maildir:" search term to +> > exactly match the maildir folder. +> +> Hi Peter - +> +> Per some discussion on IRC about the usefulness of the current "folder:" +> prefix, I went ahead and sent patches to make "folder:" a boolean prefix +> [1]. It's not the same as your "maildir:" implementation, but I believe +> you could use it to achieve the things you want with that. In +> particular, my proposed "folder:" prefix is the literal path from +> maildir root, and does not make any assumptions about maildir - i.e. it +> requires the final cur/new too. (That can be useful for some mutt users +> who need the cur/new distinction.) +> +> I am not opposed to adding another prefix like "maildir:" that does make +> assumptions on the mail storage and transformations on the path, but I +> do think it would be less important with the boolean "folder:" in place. + +Right, sorry for disappearing; I failed to find time to finish the +patch. + +I did actually modify it do loose the /new,/cur bits and I think I +addressed all other comments, including the file removal part. + +Where I got 'stuck' was writing test cases. + +Anyway, I'll try and have a look at the recent notmuch.git and see if it +does what I'd like it to. + +Thanks for getting back to me. + +~ Peter -- 2.26.2