From 97a8c848138e3637e3ba1ba7a354a4edbb0baefb Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 3 Feb 2014 16:59:27 +2000 Subject: [PATCH] Re: [PATCH] configure: only install bash completion if supported --- c7/03b11697952ecb6a8ce33b31906a643bdfeec7 | 67 +++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 c7/03b11697952ecb6a8ce33b31906a643bdfeec7 diff --git a/c7/03b11697952ecb6a8ce33b31906a643bdfeec7 b/c7/03b11697952ecb6a8ce33b31906a643bdfeec7 new file mode 100644 index 000000000..e0d4039d7 --- /dev/null +++ b/c7/03b11697952ecb6a8ce33b31906a643bdfeec7 @@ -0,0 +1,67 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B8031431FBD + for ; Sun, 2 Feb 2014 12:59:42 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id WtEZcSB6o1jg for ; + Sun, 2 Feb 2014 12:59:38 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 077C7431FBC + for ; Sun, 2 Feb 2014 12:59:38 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1WA48b-0003zD-59; Sun, 02 Feb 2014 16:59:33 -0400 +Received: (nullmailer pid 7988 invoked by uid 1000); Sun, 02 Feb 2014 + 20:59:27 -0000 +From: David Bremner +To: Mark Walters , Jani Nikula , + notmuch@notmuchmail.org +Subject: Re: [PATCH] configure: only install bash completion if supported +In-Reply-To: <877g9dqup5.fsf@qmul.ac.uk> +References: <1391359677-12497-1-git-send-email-jani@nikula.org> + <877g9dqup5.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.17~rc3 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 02 Feb 2014 16:59:27 -0400 +Message-ID: <878utt1b9s.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Feb 2014 20:59:42 -0000 + +Mark Walters writes: + +> This LGTM (untested) + +I did test it, at least completely removing bash completion works as +expected. + +Unfortunately --with-bash-completion does not override this test because +the order things are processed. Do you think this is a bug? I wondered +if users that "know what they are doing" (TM) might want to force +installation even though the pkg-config test fails. + +d + -- 2.26.2