From 975554e3f0be190c31f075a89f5499a6bc411ddf Mon Sep 17 00:00:00 2001 From: Tom Yu Date: Fri, 28 Sep 2007 23:36:00 +0000 Subject: [PATCH] pull up r19852 from trunk r19852@cathode-dark-space: jaltman | 2007-08-24 10:20:31 -0400 ticket: new subject: NIM: resource leak in khui_action_trigger() component: windows The khui_action_trigger() function in the Network Identity Manager API creates a copy of the current user interface context (which contains information about the credentials and identities that are currently selected) before triggering the requested action. Then it will use the copy to restore the user interface context to its previous state. A coding error results in the copy of the context to never be released. As a result there is a resource leak. The attached patch fixes the leak by releasing the context once it is no longer needed. ticket: 5673 version_fixed: 1.6.3 git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19987 dc483132-0cff-0310-8789-dd5450dbe970 --- src/windows/identity/uilib/action.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/windows/identity/uilib/action.c b/src/windows/identity/uilib/action.c index be3860c81..3476428ac 100644 --- a/src/windows/identity/uilib/action.c +++ b/src/windows/identity/uilib/action.c @@ -497,6 +497,7 @@ khui_action_trigger(khm_int32 action, khui_action_context * ctx) { if (ctx) { khui_context_set_indirect(&save); + khui_context_release(&save); } } -- 2.26.2