From 9720f70e029d5d500e74fc239c373ce2e473b0e0 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sat, 22 Feb 2014 21:21:19 +2000 Subject: [PATCH] Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub --- e1/c192400f3705d4cd6193ad210a2f383f1fa90b | 64 +++++++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 e1/c192400f3705d4cd6193ad210a2f383f1fa90b diff --git a/e1/c192400f3705d4cd6193ad210a2f383f1fa90b b/e1/c192400f3705d4cd6193ad210a2f383f1fa90b new file mode 100644 index 000000000..7611a6b00 --- /dev/null +++ b/e1/c192400f3705d4cd6193ad210a2f383f1fa90b @@ -0,0 +1,64 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 176DB431FBD + for ; Fri, 21 Feb 2014 17:21:34 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id NsvfKDZN0QSf for ; + Fri, 21 Feb 2014 17:21:26 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D87B4431FB6 + for ; Fri, 21 Feb 2014 17:21:26 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1WH1HQ-0007vl-Oq; Fri, 21 Feb 2014 21:21:24 -0400 +Received: (nullmailer pid 31316 invoked by uid 1000); Sat, 22 Feb 2014 + 01:21:19 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in + OrderedDict stub +In-Reply-To: <1392748492-29341-1-git-send-email-tomi.ollila@iki.fi> +References: <1392748492-29341-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 21 Feb 2014 21:21:19 -0400 +Message-ID: <87bny0x7qo.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 22 Feb 2014 01:21:34 -0000 + +Tomi Ollila writes: + +> Python dict() object does not have __values__() function which +> OrderedDict().values() (the stub provided in nmbug-status) could call +> to provide ordered list of values. By renaming this thinko to +> values() will make our stub work as expected -- dict items listed out +> in order those were added to the dictionary. + +pushed, and it looks like it fixes the date ordering problem + +d -- 2.26.2