From 9636c83a7078a8876bfd209b0b724cfdbbf3a3f8 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 4 Jan 2014 15:06:38 +0200 Subject: [PATCH] Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem --- 1d/9b2fd02ca6d3d1d2564b675d28fc0f13f1fbc3 | 86 +++++++++++++++++++++++ 1 file changed, 86 insertions(+) create mode 100644 1d/9b2fd02ca6d3d1d2564b675d28fc0f13f1fbc3 diff --git a/1d/9b2fd02ca6d3d1d2564b675d28fc0f13f1fbc3 b/1d/9b2fd02ca6d3d1d2564b675d28fc0f13f1fbc3 new file mode 100644 index 000000000..c1d671510 --- /dev/null +++ b/1d/9b2fd02ca6d3d1d2564b675d28fc0f13f1fbc3 @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8AEE4431FC0 + for ; Sat, 4 Jan 2014 05:06:54 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fekfjVMx167Q for ; + Sat, 4 Jan 2014 05:06:46 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id A59C2431FBD + for ; Sat, 4 Jan 2014 05:06:46 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 26F931000B2; + Sat, 4 Jan 2014 15:06:39 +0200 (EET) +From: Tomi Ollila +To: Thomas Klausner +Subject: Re: notmuch-0.16: realpath() compatibility issue; + clang visibility problem +In-Reply-To: <20140104125358.GW27614@danbala.tuwien.ac.at> +References: <20140103214735.GG27614@danbala.tuwien.ac.at> + + + + <20140104125358.GW27614@danbala.tuwien.ac.at> +User-Agent: Notmuch/0.17+13~gdfcf116 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 04 Jan 2014 13:06:54 -0000 + +On Sat, Jan 04 2014, Thomas Klausner wrote: + +> On Sat, Jan 04, 2014 at 02:46:37PM +0200, Jani Nikula wrote: +>> I guess we should look at realpath() compatibility, but in fairness passing +>> NULL for the second parameter is according to POSIX.1-2008, not glibc +>> extension. +> +> Ah, interesting. +> +> I can file a bug report with NetBSD about that, but in the meantime, +> it causes a coredump. :| + +The linux namual page (*) has good explanation of this in the BUGS section + +(*) http://man7.org/linux/man-pages/man3/realpath.3.html + + +After reading that I think fixing that is not as simple as your previous +patch does it -- so probably you just have to keep patching your system +until NetBSD library realpath() is POSIX.1-2008 -compatible. + +Note that having users' own patches in their systems is not uncommon +at all :D + + +> +> Thanks, +> Thomas + +Tomi -- 2.26.2