From 93027a4f6d4add77ed67e2641fbd1fd9a1b25a72 Mon Sep 17 00:00:00 2001 From: "J. Lewis Muir" Date: Thu, 2 Jul 2015 10:29:08 +1900 Subject: [PATCH] Re: [PATCH] build: Support Mac OS X 10.6.8 --- 42/5fd10364de6676eb6c0f96690e88060c5d4d9e | 71 +++++++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 42/5fd10364de6676eb6c0f96690e88060c5d4d9e diff --git a/42/5fd10364de6676eb6c0f96690e88060c5d4d9e b/42/5fd10364de6676eb6c0f96690e88060c5d4d9e new file mode 100644 index 000000000..dc6532824 --- /dev/null +++ b/42/5fd10364de6676eb6c0f96690e88060c5d4d9e @@ -0,0 +1,71 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 055DC6DE0943 + for ; Wed, 1 Jul 2015 08:29:10 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.273 +X-Spam-Level: +X-Spam-Status: No, score=0.273 tagged_above=-999 required=5 tests=[AWL=0.273] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id F4nG_eqF87j8 for ; + Wed, 1 Jul 2015 08:29:07 -0700 (PDT) +Received: from tuna.imca.aps.anl.gov (tuna.imca.aps.anl.gov [164.54.200.33]) + by arlo.cworth.org (Postfix) with ESMTP id D37CD6DE0352 + for ; Wed, 1 Jul 2015 08:29:06 -0700 (PDT) +Received: from mink.imca.aps.anl.gov (seal.imca.aps.anl.gov [164.54.200.39]) + by tuna.imca.aps.anl.gov (Postfix) with ESMTP id 58E0920067; + Wed, 1 Jul 2015 10:29:04 -0500 (CDT) +Message-ID: <55940744.7050100@imca-cat.org> +Date: Wed, 01 Jul 2015 10:29:08 -0500 +From: "J. Lewis Muir" +MIME-Version: 1.0 +To: Nate Eagleson , notmuch@notmuchmail.org +Subject: Re: [PATCH] build: Support Mac OS X 10.6.8 +References: <1435699747-13591-1-git-send-email-nate@nateeag.com> + <1435699747-13591-2-git-send-email-nate@nateeag.com> +In-Reply-To: <1435699747-13591-2-git-send-email-nate@nateeag.com> +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: 7bit +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 01 Jul 2015 15:29:10 -0000 + +On 6/30/15 4:29 PM, Nate Eagleson wrote: +> +# Mac OS X 10.6 has a built-in libutil.dylib that prevents ld from +> +# picking up notmuch's libutil.a. The best way to prefer our local +> +# libutil.a is to specify it via absolute path, which should work on +> +# all supported OSes. +> +LIBUTIL_PATH=${srcdir}/util/libutil.a + +Hi, Nate. + +I think it would be better to make the above comment not specific to OS +X, but instead just refer to "systems that have a built-in util library" +or similar. For example, NetBSD has a built-in util library [1]. I +don't have access to a FreeBSD system, but it looks like FreeBSD might +have a built-in util library too [2]. + +Similarly for the one-line commit summary since this change is not +specific to OS X. + +Regards, + +Lewis + +[1] http://netbsd.gw.com/cgi-bin/man-cgi?libutil++NetBSD-current +[2] http://svnweb.freebsd.org/base/head/lib/libutil/Makefile?view=markup -- 2.26.2