From 92b42d1c301a54d752366d798ba2704ddcd3b578 Mon Sep 17 00:00:00 2001 From: Ronny Chevalier Date: Mon, 20 Apr 2015 18:04:12 +0200 Subject: [PATCH] notmuch_thread_get_authors --- 38/af6e91e962272e3bedf00179fd7d15e6768280 | 78 +++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 38/af6e91e962272e3bedf00179fd7d15e6768280 diff --git a/38/af6e91e962272e3bedf00179fd7d15e6768280 b/38/af6e91e962272e3bedf00179fd7d15e6768280 new file mode 100644 index 000000000..34c1d140a --- /dev/null +++ b/38/af6e91e962272e3bedf00179fd7d15e6768280 @@ -0,0 +1,78 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 6B3F06DE0AC2 + for ; Mon, 20 Apr 2015 09:04:15 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.259 +X-Spam-Level: +X-Spam-Status: No, score=-0.259 tagged_above=-999 required=5 + tests=[AWL=-0.541, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, + DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, + TRACKER_ID=1.102] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 8rX0IGBP_O5Y for ; + Mon, 20 Apr 2015 09:04:13 -0700 (PDT) +Received: from mail-oi0-f53.google.com (mail-oi0-f53.google.com + [209.85.218.53]) + by arlo.cworth.org (Postfix) with ESMTPS id 54F186DE0AB8 + for ; Mon, 20 Apr 2015 09:04:13 -0700 (PDT) +Received: by oign205 with SMTP id n205so129034472oig.2 + for ; Mon, 20 Apr 2015 09:04:12 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:date:message-id:subject:from:to:content-type; + bh=qWQNvArYvMFpzHYi8aeKQizsbApdqofzG42bhWkP1mU=; + b=WqioHlpwxEP/aCMK1ebsVG7y7umUhx/fAMBEYMkv4MjtvaiWaMWTd1+sSgPLBmC2nB + sShJJPjcGknBm9C77cPfonyurQMWMHPg/GQQRLwRVoy7aO85tFs2K5s+2hNBHPBeHvA3 + Jvu8uvIRl09NPr0cUTJeMAEoFP0ICnBsp/SM6ScQaufkkH+Cr5uCDyPmOBUpGhWrNsgT + uB9IqrtzHYHYPTGqXiA5GokWpkXL1VKLVfGDxUQjiRWP7aYsbQD2lUCidZM/Lx5Zwc69 + ggq3GzoQEU9FO0K/dz2ZzpVY61GJ/C0xrRnuaG70QEAMwTi927waY1zlyp7885ZvmBdC + E7jw== +MIME-Version: 1.0 +X-Received: by 10.182.137.136 with SMTP id qi8mr14519861obb.51.1429545852325; + Mon, 20 Apr 2015 09:04:12 -0700 (PDT) +Received: by 10.202.216.5 with HTTP; Mon, 20 Apr 2015 09:04:12 -0700 (PDT) +Date: Mon, 20 Apr 2015 18:04:12 +0200 +Message-ID: + +Subject: notmuch_thread_get_authors +From: Ronny Chevalier +To: notmuch@notmuchmail.org +Content-Type: text/plain; charset=UTF-8 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 20 Apr 2015 16:04:15 -0000 + +Hi, + +I would like to know the reason behind the way we get authors from a +thread, with notmuch_thread_get_authors. + +Getting a string formatted as it is right now make it impossible to +parse properly the authors. If there is an author with | or , in its +name (or email address if there is no name), there is no way to +distinguish between another author in the list comma separated or an +author with a comma, and the same with |. + +A function like notmuch_thread_get_authors_arrays(notmuch_thread_t +*thread, char ***authors_matched, char ***authors_not_mached) with +authors_matched and authors_not_mached being string arrays +NULL-terminated could deal with this issue. + +What do you think? or maybe I am missing something? + +Ronny -- 2.26.2