From 926634a3fac57a17c3eda57fd98dae5f3c74ecd9 Mon Sep 17 00:00:00 2001 From: Felipe Contreras Date: Thu, 19 Apr 2012 17:03:50 +0300 Subject: [PATCH] Re: [PATCH v2 1/3] Add 'compose' command --- 63/04c05a1a9a973ecb9c0b7f714ecc4548700f4d | 130 ++++++++++++++++++++++ 1 file changed, 130 insertions(+) create mode 100644 63/04c05a1a9a973ecb9c0b7f714ecc4548700f4d diff --git a/63/04c05a1a9a973ecb9c0b7f714ecc4548700f4d b/63/04c05a1a9a973ecb9c0b7f714ecc4548700f4d new file mode 100644 index 000000000..000fa7a8d --- /dev/null +++ b/63/04c05a1a9a973ecb9c0b7f714ecc4548700f4d @@ -0,0 +1,130 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 33BE6431FBC + for ; Thu, 19 Apr 2012 07:03:58 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id scTrhzJSt--z for ; + Thu, 19 Apr 2012 07:03:53 -0700 (PDT) +Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com + [74.125.83.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 9FFE3431FB6 for ; Thu, 19 Apr 2012 07:03:53 -0700 + (PDT) +Received: by eekb47 with SMTP id b47so3529419eek.26 + for ; Thu, 19 Apr 2012 07:03:51 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:in-reply-to:references:date:message-id:subject:from:to + :cc:content-type; + bh=7QEjX/UaKYAndCGLL+edeVQlxZQ1WfcakxWpDz9Qw0I=; + b=zA4FTBKRi+PGShsMowN/+gGkXLXaGAmC8+wkMEwXc+ScIFGOr5rt6j6gNDZxzY7ifW + qVBiR7o4v2wIdWzkeigUJvWMMNufUPzeRl7t1TwyNr2NBuKxYujTDOKFGWO4U9RD0IET + h2QPi4vleX5ss0Btn0WAX1YOGch0Cp6bfcFICevAHbBMaOxaqV/WPtyyVbqEfAyNsln5 + 9efVCk3GKy+vQDK4CQiXP8nPmy77GTGUeeMD5x5Nv1IoxhgxbsUIcnn5eeG9Ldq0TaqC + ME13tFFxd1vLPqmxspyK1i4ufrr00M9F7ExHRzhvZJaCl+RTxqgHVdOgTt6leVsjz2xK + WW4g== +MIME-Version: 1.0 +Received: by 10.14.39.197 with SMTP id d45mr352032eeb.89.1334844230910; Thu, + 19 Apr 2012 07:03:50 -0700 (PDT) +Received: by 10.213.19.67 with HTTP; Thu, 19 Apr 2012 07:03:50 -0700 (PDT) +In-Reply-To: +References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com> + <1334752753-23970-2-git-send-email-felipe.contreras@gmail.com> + <873981chpj.fsf@nikula.org> + + <87vckxazq7.fsf@nikula.org> + + <8739819ey5.fsf@nikula.org> +Date: Thu, 19 Apr 2012 17:03:50 +0300 +Message-ID: + +Subject: Re: [PATCH v2 1/3] Add 'compose' command +From: Felipe Contreras +To: Tomi Ollila +Content-Type: text/plain; charset=UTF-8 +Cc: Felipe Contreras , notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 19 Apr 2012 14:03:58 -0000 + +On Thu, Apr 19, 2012 at 12:31 PM, Tomi Ollila wrote: +> On Wed, Apr 18 2012, Jani Nikula wrote: +> +>> On Wed, 18 Apr 2012, Felipe Contreras wrote: +>>> On Wed, Apr 18, 2012 at 5:20 PM, Jani Nikula wrote: +>>>> On Wed, 18 Apr 2012 16:34:30 +0300, Felipe Contreras wrote: +>>>>> On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula wrote: +>>>>> +>>>>> > Running "notmuch compose" more than once within a second would result in +>>>>> > identical message ids for the messages, which is not a good idea. That's +>>>>> > not likely in interactive use, but the notmuch cli is highly scriptable, +>>>>> > so someone is bound to hit this. +>>>>> > +>>>>> > Some paranoid might also be worried about "leaking" the time you run +>>>>> > "notmuch compose"... which may be different from the actual time you +>>>>> > send the message. +>>>>> +>>>>> It's still better than the current situation; nothing. In any case, +>>>>> people that have not needed this would not be affected; their UI would +>>>>> override the Message-ID. +>>>>> +>>>>> So do you have a better suggestion for a Message-ID? +>>>> +>>>> The easy way would be to just use g_mime_utils_generate_message_id() +>>>> [1]. It doesn't give you any control of the part before @, but I'm not +>>>> sure if that really matters. +>>> +>>> This is what gmime does: +>>> g_strdup_printf ("%lu.%lu.%lu@%s", (unsigned long int) time (NULL), +>>> (unsigned long int) getpid (), count++, fqdn); +>>> +>>> Which actually has some of the issues you mentioned. +>> +>> Thanks for looking into gmime source. The implementation is a bit of a +>> disappointment. +>> +>>> I can do the same if you want (add pid and count). The advantage of +>>> using our own format is that not only would it be more unique, but it +>>> would not have "@fqdn". +>> +>> I'm starting to think doing our own would be the best, although I +>> wouldn't object to using the gmime implementation "for now". +> +> I think I would be disappointed if I had to use message id:s generated +> by gmime -- just that "time leakage" problem. I guess the message-id +> is usually generated just before the mail is sent so the date in message +> id and Date: header are about equal. If message id is generated one time +> and Date: another then the time taking to write an email leaks... (except +> if Date: is also generate at 'notmuch compose' execution time (uhh ;/) +> +> Anyway, gmime implementation or something having time(NULL).getpid() +> could be used "for now". + +I agree. I was going to send a first batch of patches using gmime's +implementation for now, but since apparently I have to add a bunch of +features to my notmuch-compose patch, I'm most likely going to wait +since I'm having trouble getting even a working setup right now. + +Cheers. + +-- +Felipe Contreras -- 2.26.2