From 906ef74e2e941794df5297b5622be58d8c352e50 Mon Sep 17 00:00:00 2001 From: Aaron Bentley Date: Wed, 19 Jul 2006 10:04:27 -0400 Subject: [PATCH] Use Popen.communicate instead of reading the individual streams (why needed?) --- .bzrignore | 4 ++++ libbe/rcs.py | 5 ++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.bzrignore b/.bzrignore index 5ddfb0e..b5e0175 100644 --- a/.bzrignore +++ b/.bzrignore @@ -2,3 +2,7 @@ Bugs-Everywhere-Web/beweb/config.py ./build Bugs-Everywhere-Web/beweb/database.sqlite Bugs-Everywhere-Web/beweb/catwalk-session +*.pyc +*.~1~ +*.sw[pon] +*.shelf diff --git a/libbe/rcs.py b/libbe/rcs.py index ac96734..e7097aa 100644 --- a/libbe/rcs.py +++ b/libbe/rcs.py @@ -45,9 +45,8 @@ class CommandError(Exception): self.status = status def invoke(args, expect=(0,)): - q = Popen(args, stdin=PIPE, stdout=PIPE, stderr=PIPE) - output = q.stdout.read() - error = q.stderr.read() + q = Popen(args, stdout=PIPE, stderr=PIPE) + output, error = q.communicate() status = q.wait() if status not in expect: raise CommandError(error, status) -- 2.26.2