From 8ea050e51566f7bdcd92d7f54dc784628d508559 Mon Sep 17 00:00:00 2001 From: Peter Wang Date: Mon, 13 May 2013 23:53:38 +1000 Subject: [PATCH] Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t --- b7/a1f2be4fd5d2b9af7bf333dfedfcc69a746bd5 | 84 +++++++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 b7/a1f2be4fd5d2b9af7bf333dfedfcc69a746bd5 diff --git a/b7/a1f2be4fd5d2b9af7bf333dfedfcc69a746bd5 b/b7/a1f2be4fd5d2b9af7bf333dfedfcc69a746bd5 new file mode 100644 index 000000000..897a970d3 --- /dev/null +++ b/b7/a1f2be4fd5d2b9af7bf333dfedfcc69a746bd5 @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 17A40431FB6 + for ; Mon, 13 May 2013 06:53:52 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.099 +X-Spam-Level: +X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 0OI65rGjU-wO for ; + Mon, 13 May 2013 06:53:47 -0700 (PDT) +Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com + [209.85.192.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 33DFF431FAE + for ; Mon, 13 May 2013 06:53:47 -0700 (PDT) +Received: by mail-pd0-f174.google.com with SMTP id u10so4456310pdi.19 + for ; Mon, 13 May 2013 06:53:45 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=x-received:date:message-id:from:to:cc:subject:in-reply-to + :references:mime-version:content-type:content-disposition + :content-transfer-encoding; + bh=KRSnQYQwCjiYZl16fLFkml1pbhCArpZ8GFNIUBvQu8I=; + b=PIIdv7EnSKUU+Ubg+WaHDJpwPTZGdvfAoDA59cpu6TUlWapDj22qF0HHaFVih6WWqx + OhW2FCjCcXi482P9Hfr2B/UwmJLIZwXdVWLpWqnbRaEFlpD9ORUur7YXVHfHcZAnZDXc + rFR12HpsstbY/EeKION0h2eX3DrlRcgVUnZL/GnzpbwpvbcVf/AIcebAVQFRMHebxO+Q + h3WTXONB4BIAe8XTqdBguJ14NaDyFYBDygZvt6+u2nHjo4m/MIpWCEt+bXIPvM9xpUVv + 8zyw4mXaIiCdI/OX4EUIOWTYvVCRbfeqxrz1Ku77PxsbiZN4Ga12NiCHMVXVVNUmG2ls + VlvA== +X-Received: by 10.68.100.98 with SMTP id ex2mr24918925pbb.19.1368453225326; + Mon, 13 May 2013 06:53:45 -0700 (PDT) +Received: from localhost (215.42.233.220.static.exetel.com.au. + [220.233.42.215]) by mx.google.com with ESMTPSA id + br2sm14132896pbc.46.2013.05.13.06.53.42 for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Mon, 13 May 2013 06:53:44 -0700 (PDT) +Date: Mon, 13 May 2013 23:53:38 +1000 +Message-ID: <20130513235338.GA20690@hili.localdomain> +From: Peter Wang +To: David Bremner +Subject: Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t +In-Reply-To: <87zjw0la1n.fsf@zancas.localnet> +References: <1368301809-12532-1-git-send-email-markwalters1009@gmail.com> + <1368301809-12532-8-git-send-email-markwalters1009@gmail.com> + <87zjw0la1n.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +Content-Transfer-Encoding: 8bit +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 13 May 2013 13:53:52 -0000 + +On Sun, 12 May 2013 08:20:04 -0300, David Bremner wrote: +> Mark Walters writes: +> +> > - notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FALSE); +> > + notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FLAG); +> +> Shouldn't the documentation be updated to cover NOTMUCH_EXCLUDE_FLAG? I +> realize it is not _wrong_ as written, but it is a bit confusing not to +> cover all possible values of the enum. + +Actually, please drop patch 7 and patch 8. It was wrong to combine the +CLI-level EXCLUDE_* constants with the lib-level NOTMUCH_EXCLUDE_* constants. + +Peter -- 2.26.2