From 8d8f4ce479fd5af64b400b4e8ceb397a594a3c1b Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 14 Apr 2016 13:26:58 +0300 Subject: [PATCH] Re: [PATCH] bindings: drop build time message on missing ruby dependency --- 96/bc3a0705bcaa655e593d228b94975a7d08eed1 | 104 ++++++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100644 96/bc3a0705bcaa655e593d228b94975a7d08eed1 diff --git a/96/bc3a0705bcaa655e593d228b94975a7d08eed1 b/96/bc3a0705bcaa655e593d228b94975a7d08eed1 new file mode 100644 index 000000000..a7963c290 --- /dev/null +++ b/96/bc3a0705bcaa655e593d228b94975a7d08eed1 @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 54CAB6DE014D + for ; Thu, 14 Apr 2016 03:27:14 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.615 +X-Spam-Level: +X-Spam-Status: No, score=0.615 tagged_above=-999 required=5 tests=[AWL=-0.037, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id EAtWzXw5qdZz for ; + Thu, 14 Apr 2016 03:27:05 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 8214B6DE0127 + for ; Thu, 14 Apr 2016 03:27:05 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id A8B04100090; + Thu, 14 Apr 2016 13:26:58 +0300 (EEST) +From: Tomi Ollila +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH] bindings: drop build time message on missing ruby + dependency +In-Reply-To: <1460570925-12101-1-git-send-email-jani@nikula.org> +References: <1460570925-12101-1-git-send-email-jani@nikula.org> +User-Agent: Notmuch/0.21+99~g7cbc880 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 14 Apr 2016 10:27:14 -0000 + +On Wed, Apr 13 2016, Jani Nikula wrote: + + +LGTM. + +Tomi + + +> The usual make message on everything being up to date is: +> +> make: Nothing to be done for 'all'. +> +> However, since +> +> commit d038b9320949c79503fe4b76870aaabf279405ab +> Author: David Bremner +> Date: Mon Jun 1 09:08:59 2015 +0200 +> +> build: integrate building ruby bindings into notmuch build process +> +> if one doesn't have the ruby dependencies installed, the message has +> been: +> +> Missing dependency, skipping ruby bindings +> +> Restore the usual behaviour by dropping the message. It's redundant +> during build anyway, since the configure script already outputs: +> +> Checking for ruby development files... No (skipping ruby bindings) +> --- +> bindings/Makefile.local | 2 -- +> 1 file changed, 2 deletions(-) +> +> diff --git a/bindings/Makefile.local b/bindings/Makefile.local +> index 4ecf839d7c18..11d11d4bcbeb 100644 +> --- a/bindings/Makefile.local +> +++ b/bindings/Makefile.local +> @@ -10,8 +10,6 @@ ifeq ($(HAVE_RUBY_DEV),1) +> LIBNOTMUCH="../../lib/$(LINKER_NAME)" \ +> ruby extconf.rb --vendor +> $(MAKE) -C $(dir)/ruby +> -else +> - @echo Missing dependency, skipping ruby bindings +> endif +> +> CLEAN += $(patsubst %,$(dir)/ruby/%, \ +> -- +> 2.1.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> https://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2