From 8cdd7a8c303184c236231e3fba8a3dbc7eb7229d Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Thu, 6 Mar 2014 07:37:27 +0100 Subject: [PATCH] Re: [PATCH v2 0/7] emacs: show tag changes in buffer --- 8b/bd163c06e7a73b10ebcfbdf0f075b583aeaafe | 121 ++++++++++++++++++++++ 1 file changed, 121 insertions(+) create mode 100644 8b/bd163c06e7a73b10ebcfbdf0f075b583aeaafe diff --git a/8b/bd163c06e7a73b10ebcfbdf0f075b583aeaafe b/8b/bd163c06e7a73b10ebcfbdf0f075b583aeaafe new file mode 100644 index 000000000..8897eb322 --- /dev/null +++ b/8b/bd163c06e7a73b10ebcfbdf0f075b583aeaafe @@ -0,0 +1,121 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1CCC3431FAE + for ; Wed, 5 Mar 2014 22:37:45 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Sd7H9xlzVVTX for ; + Wed, 5 Mar 2014 22:37:38 -0800 (PST) +Received: from mail-we0-f178.google.com (mail-we0-f178.google.com + [74.125.82.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id CFBD8431FBF + for ; Wed, 5 Mar 2014 22:37:37 -0800 (PST) +Received: by mail-we0-f178.google.com with SMTP id u56so2501724wes.37 + for ; Wed, 05 Mar 2014 22:37:33 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=IaoYHz8cUIbHFUC7HMgbKUslwlrKkWOMK7s8O+/F1nc=; + b=Dfj3sdwDUB14rNGaH0/9HXte8p4nJmm/qp21n63e4lTGpuBAyAHG94BWVhnYmHuCMI + Qjz9mPg73vm40yGWtLwDnpQrT/8iq709wonZTJMamO+Ep1u836Icciu6/SWeQojE50uh + PE5ZS7Mlcq9a/EUHfFaUywMjRuAURc6cSYbgwh+TSGp5F1RkoVLd6Vs644U7/6weq8Xj + bA+wIpVUTzz+vJ97pF9Hn+aV7+DeMtm3F2cvjioZpcT94TDfS7j6mHKzlmistwwRkRsq + WIRavo4Q7tBHGBOnP9KVhuNs2XlJOQQjZXPTfo9TnBATQpjYHgeZPnk73iEUkx+hktcE + 8c5g== +X-Gm-Message-State: + ALoCoQko/u7kekOwF3zMTp851bpyZ715MVGfgAYt/DrXW7HPjJBEevsYRCqHLYyNpSzA4MGHwLEZ +X-Received: by 10.194.58.19 with SMTP id m19mr7260633wjq.30.1394087852460; + Wed, 05 Mar 2014 22:37:32 -0800 (PST) +Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3]) + by mx.google.com with ESMTPSA id ju6sm11943388wjc.1.2014.03.05.22.37.30 + for + (version=TLSv1.1 cipher=RC4-SHA bits=128/128); + Wed, 05 Mar 2014 22:37:31 -0800 (PST) +From: Jani Nikula +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/7] emacs: show tag changes in buffer +In-Reply-To: <1392841212-8494-1-git-send-email-markwalters1009@gmail.com> +References: <1392841212-8494-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.17+111~ge7301ec (http://notmuchmail.org) Emacs/23.2.1 + (x86_64-pc-linux-gnu) +Date: Thu, 06 Mar 2014 07:37:27 +0100 +Message-ID: <87zjl36deg.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 06 Mar 2014 06:37:45 -0000 + +On Wed, 19 Feb 2014, Mark Walters wrote: +> This is v2 of the patch set. Version 1 is at +> id:1390087855-26194-1-git-send-email-markwalters1009@gmail.com. +> +> The changes in this version are: use regexp tag-format matching (a +> slightly tweaked version of Austin's patch +> id:1392226351-31440-1-git-send-email-amdragon@mit.edu), make the +> tag-deleted/added formats apply on top of the normal tag-formatting, +> and fixup the way the :orig-tags field is added in notmuch-search. +> +> I think this version fixes all outstanding review comments. + +Just for the record, I've been using this version for a while (and the +previous versions before that), and I still think it's one of the best +emacs UI improvements we've had lately. Would be great to have this +merged. + +BR, +Jani. + + +> +> Best wishes +> +> Mark +> +> +> +> Austin Clements (1): +> Make keys of notmuch-tag-formats regexps and use caching +> +> Mark Walters (6): +> emacs: tag split customise option for format-tags into a widget +> emacs: tag: add customize for deleted/added tag formats +> emacs: show: mark tags changed since buffer loaded +> emacs: show: use orig-tags for tag display +> emacs: search: use orig-tags in search +> emacs: tree: use orig-tags in search +> +> emacs/notmuch-show.el | 7 ++- +> emacs/notmuch-tag.el | 179 +++++++++++++++++++++++++++++++++++++----------- +> emacs/notmuch-tree.el | 10 ++- +> emacs/notmuch.el | 41 +++++++----- +> test/test-lib.el | 5 ++ +> 5 files changed, 180 insertions(+), 62 deletions(-) +> +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2