From 8b09fa682e69f2319751b044751009ff82032608 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Mon, 13 Feb 2012 12:51:00 +1600 Subject: [PATCH] Re: [PATCH] emacs: Leave blank subjects alone by default. --- 2b/a5420417361c5774d0cabe043a3efa480d0ff0 | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 2b/a5420417361c5774d0cabe043a3efa480d0ff0 diff --git a/2b/a5420417361c5774d0cabe043a3efa480d0ff0 b/2b/a5420417361c5774d0cabe043a3efa480d0ff0 new file mode 100644 index 000000000..109ebc8e8 --- /dev/null +++ b/2b/a5420417361c5774d0cabe043a3efa480d0ff0 @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id CEDD8429E52 + for ; Sun, 12 Feb 2012 12:51:08 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 87s7Uep6JTUT for ; + Sun, 12 Feb 2012 12:51:08 -0800 (PST) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 4CA39431FAE + for ; Sun, 12 Feb 2012 12:51:08 -0800 (PST) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id BCE702E50E39; + Sun, 12 Feb 2012 12:51:03 -0800 (PST) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com + [76.174.137.84]) (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id 118D02E50D39; + Sun, 12 Feb 2012 12:51:01 -0800 (PST) +Received: by finestructure.net (Postfix, from userid 1000) + id B8E584DE; Sun, 12 Feb 2012 12:51:00 -0800 (PST) +From: Jameson Graef Rollins +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Leave blank subjects alone by default. +In-Reply-To: <1328563816-12960-1-git-send-email-dme@dme.org> +References: <1327496913-4946-1-git-send-email-dme@dme.org> + <1328563816-12960-1-git-send-email-dme@dme.org> +User-Agent: Notmuch/0.11.1+156~gde94716 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 12 Feb 2012 12:51:00 -0800 +Message-ID: <8739af3he3.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 12 Feb 2012 20:51:09 -0000 + +--=-=-= +Content-Transfer-Encoding: quoted-printable + +On Mon, 6 Feb 2012 21:30:16 +0000, David Edmondson wrote: +> Add `notmuch-blank-subject' to control how empty or whitespace only +> subjects are treated. The default behaviour is to leave them +> alone. The user can choose a string to use as a replacement. +>=20 +> Modify code that cannot handle blank subjects to use a fixed string. + +Hey, David. I still think this is a lot of unnecessary code to deal +with what seems to be an issue with notmuch-print.el only. I honestly +just don't see the point of replacing blank subjects with some other +string in all these circumstances. + +Can't we just revert the original patch and just provide the needed fix +to print.el alone? + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iQIcBAEBCAAGBQJPOCY0AAoJEO00zqvie6q8LwsQAJrbj8l3F+PVK5dwgf3K5IQm +LnPiqi37TM3np7/NMwG0mjpYBl+PdHPgz/l/02nLYXF2oCg8Bg5akMy2411lH2eo +AzcR/G1JN7pBhNFNYkRdw7ClSDP5bW+rLMM3rR9w264ZKCOYRg+Zn2+0XfltdN1x +GqRPyGPVwLrGJalvUueEtYSAqjlMi+dH3e05qsCjc+bdii9wC3jYuBWoR1P0GqLC +fpBovHj8BCtQWFJNcVQb3BR+vHn78JMYq6UlG6bODt1AkSXHwdZXG2ku1Oukci2Z +vo1IZWZi+WYtU6cU2KJSS4vFb/CP5UBlb4R96g2BWIy/GMB4GICidM4hoe3Ug6CO +gJWKihk+RmeVj/uvcE1x1iQhbAyCTLRBnhho/EzRwfYsxNHppVdv4TVbgxXZy1zR +HRvpLP4WfitTBEUVu5SdMaRsdKfFZX/XdNf643qVO+HgE7rLeNPME62w+dZg8KxJ +BpAY8rjiOJTC92eI7cqw3iVmdWp5Lh5D+It/in79467Q4w5tegBQfwuA1LIVhkLG +m/GkmShCoz3UQbParAf9bDbmguHuEYWh97mR4Bbt/9OhcbDWyT3HkB6d3+Q3yHEX +M8dNVmI9l6PXSkk5R3AGVxO+8boJ8BnyrhstFkM2l8AL2XOZ42bOQ9YGZc3SzeTF ++DxfgykHVn31Ol39BGMw +=QEaW +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2