From 8ac140112e46c25c34a2caff25496892bba28b54 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 25 Oct 2015 22:26:08 +0200 Subject: [PATCH] Re: elisp + company completion patches, v7 --- 1e/9918ab581ee12ff01276728ce8784738b72641 | 79 +++++++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 1e/9918ab581ee12ff01276728ce8784738b72641 diff --git a/1e/9918ab581ee12ff01276728ce8784738b72641 b/1e/9918ab581ee12ff01276728ce8784738b72641 new file mode 100644 index 000000000..dd1d0535c --- /dev/null +++ b/1e/9918ab581ee12ff01276728ce8784738b72641 @@ -0,0 +1,79 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 6A0216DE1585 + for ; Sun, 25 Oct 2015 13:26:16 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.118 +X-Spam-Level: * +X-Spam-Status: No, score=1.118 tagged_above=-999 required=5 tests=[AWL=-0.278, + SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id D1b1YAwxdL-N for ; + Sun, 25 Oct 2015 13:26:14 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id BA21D6DE14FD + for ; Sun, 25 Oct 2015 13:26:13 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 79AF0100046; + Sun, 25 Oct 2015 22:26:08 +0200 (EET) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: elisp + company completion patches, v7 +In-Reply-To: <1445786638-13763-1-git-send-email-david@tethera.net> +References: <1445786638-13763-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 25 Oct 2015 20:26:16 -0000 + +On Sun, Oct 25 2015, David Bremner wrote: + +> This round contains several bug fixes from Mark, and a slightly +> re-organized initialization from me. In particular, TAB should now +> behave sanely under company. Also there's a stub +> notmuch-address-message-insinuate to prevent peoples emacs startup +> from failing. + +Looks pretty good, I, like Mark, noticed some newline changes in patch 1 +(which is fixed in patch 2 so I personally would not care of that). The +another indentation thing Mark noticed is easy to amend. + +I, if this does not sound nitpicking, would amend those 'This patch' and +'With this patch' texts in commit messages away by some rewording -- those +pose as a bad example for someone reading the code -- and diminish the +effect when I complain that again in future patched ;) + +The basic completion with this new system using notmuch address output +and (supposedly) caching the values seems to work very well and I believe +is welcome feature to (new) users. I did not test how company mode works +as I don't have it (and there is no company mode for this mixed environment +what I use now -- except that I could install it from elpa; maybe I try +that in near future...) + +BTW: if anyone knows how to enable lexical-binding to a block of code +(i.e. alternative to -*- lexical-binding: t -*- (or can give hints, like +s/\([^-]\)let/\1lexical-let/) I'd like to know...) + +Tomi -- 2.26.2