From 88cb52d393f277513c9c240192e9a4b74acea145 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Wed, 28 Oct 2015 08:00:11 +0000 Subject: [PATCH] Re: [PATCH 3/4] emacs: add function to resend message to new recipients --- a4/df2d062aa6a12554e185f3bc456de158543239 | 173 ++++++++++++++++++++++ 1 file changed, 173 insertions(+) create mode 100644 a4/df2d062aa6a12554e185f3bc456de158543239 diff --git a/a4/df2d062aa6a12554e185f3bc456de158543239 b/a4/df2d062aa6a12554e185f3bc456de158543239 new file mode 100644 index 000000000..e43cb12ed --- /dev/null +++ b/a4/df2d062aa6a12554e185f3bc456de158543239 @@ -0,0 +1,173 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 9992A6DE13EF + for ; Wed, 28 Oct 2015 01:00:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -1.393 +X-Spam-Level: +X-Spam-Status: No, score=-1.393 tagged_above=-999 required=5 + tests=[AWL=-0.823, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, + DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5MvA-_LK0tAn for ; + Wed, 28 Oct 2015 01:00:20 -0700 (PDT) +Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com + [209.85.212.180]) + by arlo.cworth.org (Postfix) with ESMTPS id 858BD6DE0B44 + for ; Wed, 28 Oct 2015 01:00:19 -0700 (PDT) +Received: by wicll6 with SMTP id ll6so188737292wic.0 + for ; Wed, 28 Oct 2015 01:00:17 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type; + bh=YETvpa/GYLvIHit0pS+LWi4FQ4SEw+vGZjJsdLXsz5A=; + b=Ecbt/CTb9azyPhaF/TYOjo+g7bninW1k46SLKeibwc5QClxsWg7riNy0Avj+Aaz5Ea + KkFy4bto+gwcCme3igybFwJ93cRaz/NMgV/j4ZP0Fh5qXwat0VMUYm9rulEaxx/jt83u + EO2LjJCzpELQ6R/kCrLaf96irNFu/rsM4ZGhmHq8ivCIChthg9TuMIm6p2Qbqba354Ae + I3/P0b/C5f+mq9mAcyR57rSPAPStiTamMFKpcpc6nY5vf5lDTyqOjlN1PHFHtHoOKS7s + hrWgGovsNL2cZxtX36aIfrjOntNAfgflUYjHdxTbey3p1Q4xfoTUhuySvZOW2Tj2N1if + 2HFA== +X-Received: by 10.180.210.234 with SMTP id mx10mr1397018wic.31.1446019217719; + Wed, 28 Oct 2015 01:00:17 -0700 (PDT) +Received: from localhost (188.30.196.178.threembb.co.uk. [188.30.196.178]) + by smtp.gmail.com with ESMTPSA id jf13sm20404233wic.8.2015.10.28.01.00.13 + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Wed, 28 Oct 2015 01:00:17 -0700 (PDT) +From: Mark Walters +To: Tomi Ollila , notmuch@notmuchmail.org +Cc: tomi.ollila@iki.fi +Subject: Re: [PATCH 3/4] emacs: add function to resend message to new + recipients +In-Reply-To: <1441204482-26509-3-git-send-email-tomi.ollila@iki.fi> +References: <1441204482-26509-1-git-send-email-tomi.ollila@iki.fi> + <1441204482-26509-3-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.18+469~gb743c48 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 28 Oct 2015 08:00:11 +0000 +Message-ID: <87pozza0dw.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 28 Oct 2015 08:00:22 -0000 + + +On Wed, 02 Sep 2015, Tomi Ollila wrote: +> The new function notmuch-show-message-resend re-sends +> message to new recipients using #'message-resend. +> +> Recipients are read from minibuffer as a comma-separated +> string (with some keyboard support including tab completion). +> +> Final confirmation before sending is asked. +> --- + +This series looks good to me modulo three minor comments (I even +like the choice of binding to b). + +The first comment is that, in light of the recent address series, I +think Patch 2 can be dropped completely, with a small change to this +patch. See below for that, and the other two minor suggestions. + +Also, I wonder if when it gets a NEWS item it might be worth mentioning +that a user might have already added this function to their emacs init +file as it has been on the wiki. (It took me way too long to realise +that was why this patch was not working for me!) + +Best wishes + +Mark + + +> +> Since id:1440619626-18768-2-git-send-email-tomi.ollila@iki.fi +> - changed (bury-buffer) to (notmuch-bury-or-kill-this-buffer) +> - it is hard to have the buffer been kept around but it is posiible +> +> emacs/notmuch-address.el | 19 +++++++++++++++++++ +> emacs/notmuch-show.el | 8 ++++++++ +> 2 files changed, 27 insertions(+) +> +> diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el +> index 8982a415ce11..83788efd3c1b 100644 +> --- a/emacs/notmuch-address.el +> +++ b/emacs/notmuch-address.el +> @@ -119,4 +119,23 @@ (defun notmuch-address-locate-command (command) +> +> ;; +> +> +(defun notmuch-address-from-minibuffer (prompt) +> + (if (not (notmuch-address--message-insinuated)) +> + (read-string prompt) + +This can become + (if (not notmuch-address-command) + +> + (let ((rmap (copy-keymap minibuffer-local-map)) +> + (omap minibuffer-local-map)) +> + ;; Configure TAB to start completion when executing read-string. +> + ;; "Original" minibuffer keymap is restored just before calling +> + ;; notmuch-address-expand-name as it may also use minibuffer-local-map +> + ;; (completing-read probably does not but if something else is used there). +> + (define-key rmap "\C-i" (lambda () ;; TAB + +I think this could become (define-key rmap (kbd "TAB") (lambda () .... + +which is easy to read and consistent with the definitions of other +keymaps (eg the main notmuch-show keymap). + +> + (interactive) +> + (let ((enable-recursive-minibuffers t) +> + (minibuffer-local-map omap)) +> + (notmuch-address-expand-name)))) +> + (let ((minibuffer-local-map rmap)) +> + (read-string prompt))))) +> + +> +;; +> + +> (provide 'notmuch-address) +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index 0565ab0725b2..046cb0e41f0b 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -1806,6 +1806,14 @@ (defun notmuch-show-forward-message (&optional prompt-for-sender) +> (with-current-notmuch-show-message +> (notmuch-mua-new-forward-message prompt-for-sender))) +> +> +(defun notmuch-show-resend-message (addresses) +> + "Resend the current message." +> + (interactive (list (notmuch-address-from-minibuffer "Resend to: "))) +> + (when (yes-or-no-p (concat "Confirm resend to " addresses " ")) + +Perhaps y-or-n-p rather than yes-or-no-p? + +> + (notmuch-show-view-raw-message) +> + (message-resend addresses) +> + (notmuch-bury-or-kill-this-buffer))) +> + +> (defun notmuch-show-next-message (&optional pop-at-end) +> "Show the next message. +> +> -- +> 2.0.0 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2