From 889dd6c698a7cbcba7b212114a4b4a5964ac6048 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Mon, 8 Sep 2014 19:10:25 +0300 Subject: [PATCH] Re: [Patch v2 1/2] emacs: show: document the mark unread defcustom function --- 3e/af1df3c3293e6fe8ad6f6a4d0987f5ce155b10 | 99 +++++++++++++++++++++++ 1 file changed, 99 insertions(+) create mode 100644 3e/af1df3c3293e6fe8ad6f6a4d0987f5ce155b10 diff --git a/3e/af1df3c3293e6fe8ad6f6a4d0987f5ce155b10 b/3e/af1df3c3293e6fe8ad6f6a4d0987f5ce155b10 new file mode 100644 index 000000000..ebee0dfe5 --- /dev/null +++ b/3e/af1df3c3293e6fe8ad6f6a4d0987f5ce155b10 @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4DE72431FBC + for ; Mon, 8 Sep 2014 09:10:49 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id PB+2lSPtqlNv for ; + Mon, 8 Sep 2014 09:10:43 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id C9234431FB6 + for ; Mon, 8 Sep 2014 09:10:42 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id CDFA410008C; + Mon, 8 Sep 2014 19:10:25 +0300 (EEST) +From: Tomi Ollila +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [Patch v2 1/2] emacs: show: document the mark unread + defcustom function +In-Reply-To: <1410020531-24419-2-git-send-email-markwalters1009@gmail.com> +References: <1410020531-24419-1-git-send-email-markwalters1009@gmail.com> + <1410020531-24419-2-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.18.1+93~gaa65b5d (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 08 Sep 2014 16:10:49 -0000 + +On Sat, Sep 06 2014, Mark Walters wrote: + +> --- +> emacs/notmuch-show.el | 8 +++++++- +> 1 file changed, 7 insertions(+), 1 deletion(-) +> +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index 7549fbb..5695d95 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -224,7 +224,13 @@ For example, if you wanted to remove an \"unread\" tag and add a +> :group 'notmuch-show) +> +> (defcustom notmuch-show-mark-read-function #'notmuch-show-seen-current-message +> - "Function to control which messages are marked read." +> + "Function to control which messages are marked read. +> + +> +The function should take two arguments START and END which will +> +be the start and end of the visible portion of the buffer and +> +should mark the appropriate messages read by applying +> +`notmuch-show-mark-read'. This function will be called after +> +every user interaction with notmuch." + +This patch LGTM. Now that we know more I would have liked this function +would not take the START & END parameters but the function itself could +have done (window-start) (window-end) if it so desires... + +... as we have discussed in IRC my current version uses (point) in place +of END (window-end) and I may drop START too (while investigating Mark's +IRC-given suggestions). + +Anyway, the ship may have sailed and therefore I am inclined to give +1 +to this patch... + +Tomi + + +> :type 'function +> :group 'notmuch-show) +> +> -- +> 1.7.10.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2