From 86021254f4967f548b22bc5ffe6c3b46ed328f00 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 29 Mar 2015 00:46:20 +0100 Subject: [PATCH] Re: [Patch v6 4/8] lib: add "verbose" versions of notmuch_database_{open,create} --- 05/fcf35b57c6d7ed589a0a6f35b8e1dd1ccec2d7 | 72 +++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 05/fcf35b57c6d7ed589a0a6f35b8e1dd1ccec2d7 diff --git a/05/fcf35b57c6d7ed589a0a6f35b8e1dd1ccec2d7 b/05/fcf35b57c6d7ed589a0a6f35b8e1dd1ccec2d7 new file mode 100644 index 000000000..53714c2a5 --- /dev/null +++ b/05/fcf35b57c6d7ed589a0a6f35b8e1dd1ccec2d7 @@ -0,0 +1,72 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id AEF4C431FC2 + for ; Sat, 28 Mar 2015 16:47:37 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.438 +X-Spam-Level: ** +X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id msrHesNwSijV for ; + Sat, 28 Mar 2015 16:47:34 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 6BD67431FAE + for ; Sat, 28 Mar 2015 16:47:34 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.80) (envelope-from ) + id 1Yc0R0-0006uz-3b; Sat, 28 Mar 2015 23:46:34 +0000 +Received: (nullmailer pid 7463 invoked by uid 1000); Sat, 28 Mar 2015 + 23:46:20 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [Patch v6 4/8] lib: add "verbose" versions of + notmuch_database_{open,create} +In-Reply-To: +References: <1427494320-1483-1-git-send-email-david@tethera.net> + <1427494320-1483-5-git-send-email-david@tethera.net> + +User-Agent: Notmuch/0.19+86~gbed8b67 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 29 Mar 2015 00:46:20 +0100 +Message-ID: <87twx4ptwz.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 28 Mar 2015 23:47:37 -0000 + +Tomi Ollila writes: + +> +> Just that this small piece of code above git pass my sparse sieve, perhaps +> this could be amended to: +> +> if (message) { +> if (status_string) +> *status_string = message; +> else +> free(message); +> } +> + +I amended and pushed. Thanks for all the reviewing. + +d -- 2.26.2