From 81214e4ddf2f0114ce7756a014dc533340fcb3f9 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Thu, 5 Jan 2006 19:42:12 -0800 Subject: [PATCH] git-fetch --tags: reject malformed tags. When the other end was prepared with older git and has tags that do not follow the naming convention (see check-ref-format), do not barf but simply reject to copy them. Initial fix by Simon Richter, but done differently. Signed-off-by: Junio C Hamano --- git-fetch.sh | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/git-fetch.sh b/git-fetch.sh index 125bcea1b..b46b3e558 100755 --- a/git-fetch.sh +++ b/git-fetch.sh @@ -188,11 +188,20 @@ esac reflist=$(get_remote_refs_for_fetch "$@") if test "$tags" then - taglist=$(git-ls-remote --tags "$remote" | - sed -e ' - /\^/d - s/^[^ ]* // - s/.*/.&:&/') + taglist=$(IFS=" " && + git-ls-remote --tags "$remote" | + while read sha1 name + do + case "$name" in + (*^*) continue ;; + esac + if git-check-ref-format "$name" + then + echo ".${name}:${name}" + else + echo >&2 "warning: tag ${name} ignored" + fi + done) if test "$#" -gt 1 then # remote URL plus explicit refspecs; we need to merge them. -- 2.26.2