From 80196742dc9a8de2c12786876915dae82956873f Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Wed, 4 Dec 2013 21:27:29 +0200 Subject: [PATCH] Re: [PATCH 1/1] emacs: Makefile.local: HAVE_EMACS usage fixes --- a8/18631c06218cc02f5a57ff5735a54b0b06b19b | 93 +++++++++++++++++++++++ 1 file changed, 93 insertions(+) create mode 100644 a8/18631c06218cc02f5a57ff5735a54b0b06b19b diff --git a/a8/18631c06218cc02f5a57ff5735a54b0b06b19b b/a8/18631c06218cc02f5a57ff5735a54b0b06b19b new file mode 100644 index 000000000..ace41213b --- /dev/null +++ b/a8/18631c06218cc02f5a57ff5735a54b0b06b19b @@ -0,0 +1,93 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D03D8431FD7 + for ; Wed, 4 Dec 2013 11:27:45 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id rYKgK2s4g5Oy for ; + Wed, 4 Dec 2013 11:27:36 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 9099D431FD0 + for ; Wed, 4 Dec 2013 11:27:36 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 406E3100086; + Wed, 4 Dec 2013 21:27:30 +0200 (EET) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/1] emacs: Makefile.local: HAVE_EMACS usage fixes +In-Reply-To: <87ob523snl.fsf@zancas.localnet> +References: <1377630047-27756-1-git-send-email-tomi.ollila@iki.fi> + <87ob523snl.fsf@zancas.localnet> +User-Agent: Notmuch/0.17~rc1+17~ga2e1a2f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 04 Dec 2013 19:27:46 -0000 + +On Sat, Nov 30 2013, David Bremner wrote: + +> Tomi Ollila writes: +> +>> +>> ifeq ($(WITH_EMACS),1) +>> ifeq ($(HAVE_EMACS),1) +>> all: $(emacs_bytecode) +>> +install-emacs: $(emacs_bytecode) +>> endif +>> +> +> It's a bit confusing that we have both HAVE_EMACS and WITH_EMACS. Should +> this be documented somewhere? Otherwise the patch seems sensible. +> +> See also the discussion at id:528B455A.70200@iki.fi. + +Eventually it's probably good idea to merge HAVE_EMACS to WITH_EMACS but +doing in a good way requires quite a few ./configure changes (and while +doing that one have to check that some consistency is kept). +Eventually it would probably be nice that in case *_EMACS is not set (is 0) +the clean rules stay (provided that those do not require emacs) but +build rules are ifdeffed out... + +In the meantime my patch here maintains status quo where things can be +done in case HAVE_EMACS is set (1) -- emacs is available in the system, +while keeping the cleanup rules in case *_EMACS is not set... and +this patch also fixes the compilation whenever there is no emacs in system. + +I could add short notes of what HAVE_EMACS & WITH_EMACS mean but although +it is bit confusing that we currently have both, those are nevertheless +quite descriptive themselves. + +> +> d + +Tomi + +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2