From 7f6610f249128b07c5e88cab87feb0d51266b07d Mon Sep 17 00:00:00 2001 From: www-data Date: Wed, 15 Mar 2006 06:02:57 +0000 Subject: [PATCH] web commit by joey --- doc/security.mdwn | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/security.mdwn b/doc/security.mdwn index 252239331..0564fdb8e 100644 --- a/doc/security.mdwn +++ b/doc/security.mdwn @@ -71,10 +71,12 @@ this wiki, BTW. ## svn commit logs -Currently html is not escape in svn commit logs, this should probably be fixed. - Anyone with svn commit access can forge "web commit from foo" and make it appeat on [[RecentChanges]] like foo committed. One way to avoid this would be to limit web commits to those done by a certian user. +It's actually possible to force a whole series of svn commits to appear to have come just before yours, by forging svn log output. This could be guarded against somewhat by revision number scanning, since the forged revisions would duplicate the numbers of unforged ones. Or subversion could fix svn log to indent commit messages, which would make such forgery impossible.. + +ikiwiki escapes any html in svn commit logs to prevent other mischief. + ---- # Hopefully non-holes -- 2.26.2