From 7f3db57c5feb631f6ff45b40ec45f1721e144a1c Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Fri, 19 Oct 2007 19:33:38 +0000 Subject: [PATCH] Refactor _merge_logentries() to make it a little more efficient. svn path=/main/trunk/; revision=8184 --- pym/portage/elog/__init__.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/pym/portage/elog/__init__.py b/pym/portage/elog/__init__.py index b9cc3f659..e1df6d9bd 100644 --- a/pym/portage/elog/__init__.py +++ b/pym/portage/elog/__init__.py @@ -18,13 +18,12 @@ def _merge_logentries(a, b): phases = set(a) phases.update(b) for p in phases: - rValue[p] = [] - if a.has_key(p): - for x in a[p]: - rValue[p].append(x) - if b.has_key(p): - for x in b[p]: - rValue[p].append(x) + merged_msgs = [] + rValue[p] = merged_msgs + for d in a, b: + msgs = d.get(p) + if msgs: + merged_msgs.extend(msgs) return rValue def _combine_logentries(logentries): -- 2.26.2