From 7ea8fb78a83492af8131243df6ea10ce1ca02ad8 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 15 Sep 2013 11:36:19 +0300 Subject: [PATCH] Re: [PATCH] contrib: pick: bugfix use of mini-buffer history --- eb/f0a9787952b248a54cdd4b518d6a976dc9a390 | 85 +++++++++++++++++++++++ 1 file changed, 85 insertions(+) create mode 100644 eb/f0a9787952b248a54cdd4b518d6a976dc9a390 diff --git a/eb/f0a9787952b248a54cdd4b518d6a976dc9a390 b/eb/f0a9787952b248a54cdd4b518d6a976dc9a390 new file mode 100644 index 000000000..ce90c311e --- /dev/null +++ b/eb/f0a9787952b248a54cdd4b518d6a976dc9a390 @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 38989431FBD + for ; Sun, 15 Sep 2013 01:36:29 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id J4s1Gt4ioJZA for ; + Sun, 15 Sep 2013 01:36:25 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 92645431FAE + for ; Sun, 15 Sep 2013 01:36:25 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 7B2E61000B2; + Sun, 15 Sep 2013 11:36:19 +0300 (EEST) +From: Tomi Ollila +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] contrib: pick: bugfix use of mini-buffer history +In-Reply-To: <1379233173-9812-1-git-send-email-markwalters1009@gmail.com> +References: <1379233173-9812-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.16+77~g2561895 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 15 Sep 2013 08:36:29 -0000 + +On Sun, Sep 15 2013, Mark Walters wrote: + +> pick was meant to use the same mini-buffer history but this failed +> because the interactive definition took place before the use search +> mini-buffer history part. Remove the interactive prompt to ensure the +> correct history is used. +> --- + +LGTM. + +Tomi + +> contrib/notmuch-pick/notmuch-pick.el | 2 +- +> 1 files changed, 1 insertions(+), 1 deletions(-) +> +> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el +> index 01ca4bd..ad85d03 100644 +> --- a/contrib/notmuch-pick/notmuch-pick.el +> +++ b/contrib/notmuch-pick/notmuch-pick.el +> @@ -948,7 +948,7 @@ The arguments are: +> BUFFER-NAME: the name of the buffer to show the pick tree. If +> it is nil \"*notmuch-pick\" followed by QUERY is used. +> OPEN-TARGET: If TRUE open the target message in the message pane." +> - (interactive "sNotmuch pick: ") +> + (interactive) +> (if (null query) +> (setq query (notmuch-read-query "Notmuch pick: "))) +> (let ((buffer (get-buffer-create (generate-new-buffer-name +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2