From 7e0044812f10d29bb0146e060fbf082ae784d271 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 5 Oct 2014 10:56:44 +0200 Subject: [PATCH] Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature --- 06/3beaf3e07d562981d5aaf346003ed7874b8204 | 68 +++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 06/3beaf3e07d562981d5aaf346003ed7874b8204 diff --git a/06/3beaf3e07d562981d5aaf346003ed7874b8204 b/06/3beaf3e07d562981d5aaf346003ed7874b8204 new file mode 100644 index 000000000..1e85b025f --- /dev/null +++ b/06/3beaf3e07d562981d5aaf346003ed7874b8204 @@ -0,0 +1,68 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1EE6A431FC3 + for ; Sun, 5 Oct 2014 01:56:59 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 1lic-FtOHtVp for ; + Sun, 5 Oct 2014 01:56:55 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id AEB78431FB6 + for ; Sun, 5 Oct 2014 01:56:55 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1Xahcc-0007mr-UE; Sun, 05 Oct 2014 05:56:54 -0300 +Received: (nullmailer pid 14365 invoked by uid 1000); Sun, 05 Oct 2014 + 08:56:44 -0000 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature +In-Reply-To: <1412345958-8278-9-git-send-email-aclements@csail.mit.edu> +References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu> + <1412345958-8278-9-git-send-email-aclements@csail.mit.edu> +User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 05 Oct 2014 10:56:44 +0200 +Message-ID: <87d2a6q4hf.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 Oct 2014 08:56:59 -0000 + +Austin Clements writes: +> + if (new_features & NOTMUCH_FEATURE_GHOSTS) { +> + t_end = db->metadata_keys_end ("thread_id_"); +> + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t) +> + ++total; +> + } + +It would be nice to have the comment below, or something like it, for +the loop above. + +> + /* Perform metadata upgrades. */ +> + +> + /* Prior to NOTMUCH_FEATURE_GHOSTS, thread IDs for missing +> + * messages were stored as database metadata. Change these to +> + * ghost messages. +> + */ -- 2.26.2