From 7d047838d8c837e8679795d4feb8a608a829e4dd Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sat, 25 May 2013 14:02:41 +0300 Subject: [PATCH] Re: [PATCH 2/4] test: added --stderr=FILE tests --- 69/c0587bd58eff1090f20af55f7266e0373eefea | 107 ++++++++++++++++++++++ 1 file changed, 107 insertions(+) create mode 100644 69/c0587bd58eff1090f20af55f7266e0373eefea diff --git a/69/c0587bd58eff1090f20af55f7266e0373eefea b/69/c0587bd58eff1090f20af55f7266e0373eefea new file mode 100644 index 000000000..8115d7e35 --- /dev/null +++ b/69/c0587bd58eff1090f20af55f7266e0373eefea @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BA2EF431FAF + for ; Sat, 25 May 2013 04:03:06 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id TGXnN+AYrOQn for ; + Sat, 25 May 2013 04:02:56 -0700 (PDT) +Received: from mail-la0-f43.google.com (mail-la0-f43.google.com + [209.85.215.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 18D27431FAE + for ; Sat, 25 May 2013 04:02:55 -0700 (PDT) +Received: by mail-la0-f43.google.com with SMTP id ez20so5272674lab.30 + for ; Sat, 25 May 2013 04:02:53 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:x-gm-message-state; + bh=1oZgPVQUrKFpadvW3h/6FjtwA0AvwGLHP9ar3Z+RwSk=; + b=k+LzhXuqugZQPbZJ7QGrCldLyB/1F62PYHcZtGxwVvoxMCQSQkQ2/boeDgXBP1uoq3 + JvgObgPHoQgvTezDZ0zdvUIjHDrxFahO1K1EdE0JHcFUMfNy9rDLosex88zrdCMCRRku + fjrLIVHBiRZl58OYROluvxqFnyRoTQ/T9HbgkiBrNFzf6Y/SvSO6mgcgZFU0ti5gMe3I + CjBMfejmJq3jo5mEKbBwr6R8rSKYqcTa23Uz4aqYU7EMJ17bT+MSBFKgQWfi7OgOn7Gx + fsB7RrhIzlAaXloeKREptjHPIc+4IcKFnZnn3aSeOMJtWWuQvKrPlLJ/d58gcjpUBbnX + MSUA== +X-Received: by 10.152.116.7 with SMTP id js7mr5940109lab.7.1369479771989; + Sat, 25 May 2013 04:02:51 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw2-58c376-211.dhcp.inet.fi. + [88.195.118.211]) + by mx.google.com with ESMTPSA id uo8sm6183974lbb.5.2013.05.25.04.02.50 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sat, 25 May 2013 04:02:50 -0700 (PDT) +From: Jani Nikula +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/4] test: added --stderr=FILE tests +In-Reply-To: <87k3mo3iv8.fsf@nikula.org> +References: <1369332362-4719-1-git-send-email-tomi.ollila@iki.fi> + <1369332362-4719-2-git-send-email-tomi.ollila@iki.fi> + <87k3mo3iv8.fsf@nikula.org> +User-Agent: Notmuch/0.15.2+87~gc69f540 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 25 May 2013 14:02:41 +0300 +Message-ID: <87hahr1fvy.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-Gm-Message-State: + ALoCoQkTwNeI6EiJGoQZ1JTfDJBH+xBaJDpXF1giyw5/umWiK9ISkkJYo7lX3v1DLmbbSUavgV5H +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 25 May 2013 11:03:06 -0000 + +On Fri, 24 May 2013, Jani Nikula wrote: +> On Thu, 23 May 2013, Tomi Ollila wrote: +>> --stderr=FILE tests were added to test/help-test as it is the one +>> doing most global option testing. Also, it was simplest to test +>> this new option using `notmuch help` command. +>> --- +>> +>> In the future this file (help-test) could be renamed and used in +>> more generic "global option" testing +>> +>> test/help-test | 10 ++++++++++ +>> 1 file changed, 10 insertions(+) +>> +>> diff --git a/test/help-test b/test/help-test +>> index f7df725..8b77931 100755 +>> --- a/test/help-test +>> +++ b/test/help-test +>> @@ -9,4 +9,14 @@ test_expect_success 'notmuch help' 'notmuch help' +>> test_expect_success 'notmuch help tag' 'notmuch help tag' +>> test_expect_success 'notmuch --version' 'notmuch --version' +>> +>> +test_begin_subtest "notmuch --stderr=stderr help %" +>> +notmuch --stderr=stderr help % +>> +test_expect_equal "$(cat stderr)" " +>> +Sorry, % is not a known command. There's not much I can do to help." +>> + +>> +test_begin_subtest "notmuch --stderr=- help %" +>> +notmuch --stderr=stderr help % +> +> Leftover line from copy-paste? + +Apart from this, the whole series LGTM. + +BR, +Jani. -- 2.26.2