From 7bd22d4925df5111b71858f2811d2d4fd8cfe33b Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Sun, 11 May 2014 12:02:30 +2000 Subject: [PATCH] Re: [PATCH] doc: Fix parallel build of roff files --- 86/d0939c5332635c0cd21e053b2dc65b478251d4 | 109 ++++++++++++++++++++++ 1 file changed, 109 insertions(+) create mode 100644 86/d0939c5332635c0cd21e053b2dc65b478251d4 diff --git a/86/d0939c5332635c0cd21e053b2dc65b478251d4 b/86/d0939c5332635c0cd21e053b2dc65b478251d4 new file mode 100644 index 000000000..4aee8928d --- /dev/null +++ b/86/d0939c5332635c0cd21e053b2dc65b478251d4 @@ -0,0 +1,109 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 32930431FC0 + for ; Sat, 10 May 2014 09:02:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 70PevnmNGvFv for ; + Sat, 10 May 2014 09:02:39 -0700 (PDT) +Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu + [18.9.25.13]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 7617B431FBF + for ; Sat, 10 May 2014 09:02:39 -0700 (PDT) +X-AuditID: 1209190d-f798f6d000000c3b-e2-536e4d9dffc2 +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + (using TLS with cipher AES256-SHA (256/256 bits)) + (Client did not present a certificate) + by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP + id EC.7C.03131.D9D4E635; Sat, 10 May 2014 12:02:37 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id s4AG2aat017307; + Sat, 10 May 2014 12:02:37 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s4AG2X2l020911 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Sat, 10 May 2014 12:02:35 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1Wj9jL-0000oN-Sz; Sat, 10 May 2014 12:02:32 -0400 +From: Austin Clements +To: "W. Trevor King" +Subject: Re: [PATCH] doc: Fix parallel build of roff files +In-Reply-To: <20140510151833.GR28634@odin.tremily.us> +References: <1397766897-14475-1-git-send-email-amdragon@mit.edu> + <20140510151833.GR28634@odin.tremily.us> +User-Agent: Notmuch/0.18~rc1+6~gecef282 (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Sat, 10 May 2014 12:02:30 -0400 +Message-ID: <874n0xoc4p.fsf@awakening.csail.mit.edu> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFvrOIsWRmVeSWpSXmKPExsUixG6nojvXNy/YYP1uU4vrN2cyW1xZc57d + gcnj2apbzB67v/9kCWCK4rJJSc3JLEst0rdL4Mo43iZY0MRZcfHOBLYGxrnsXYycHBICJhIH + Pr5ihLDFJC7cW8/WxcjFISQwm0li8c0TLBDORkaJVwf6mEGqhAROM0k861CESCxhlDg97QMb + SIJNQENi2/7lYKNEBNQlNqxYARZnFpCW+Pa7mQnEFhawkjjRMw3M5hQwlWg/+IUdYmimxPSO + r2C2qECixMlVj8BqWARUJY5c3AJkc3DwAp16YakkSJhXQFDi5MwnLBDjtSRu/HvJNIFRcBaS + 1CwkqQWMTKsYZVNyq3RzEzNzilOTdYuTE/PyUot0jfRyM0v0UlNKNzGCwpRTkncH47uDSocY + BTgYlXh4C97mBAuxJpYVV+YeYpTkYFIS5fV2ywsW4kvKT6nMSCzOiC8qzUktPsQowcGsJMK7 + XRcox5uSWFmVWpQPk5LmYFES531rbRUsJJCeWJKanZpakFoEk5Xh4FCS4P3tDdQoWJSanlqR + lplTgpBm4uAEGc4DNPwHSA1vcUFibnFmOkT+FKMux4Ifa1qYhFjy8vNSpcR5l4IUCYAUZZTm + wc2BpZdXjOJAbwnz/gGp4gGmJrhJr4CWMAEt8dXPBllSkoiQkmpg5DJZajvF998++Rees4uC + rvkfDlzAGDJPIl56l9AviQlS/VcFW00Z3q73jDU5JJh5/NsO1midHSwRfd8zqo63fnmzd37Q + 0qdlLBKzsq5OO7hiz+F3HSziwY9ndNr4Hpbat7iSaWnbi6znPMuZfop+uVz/6KV/ZF7K7Mmc + y5g8F3BfMpoWOX+7qhJLcUaioRZzUXEiANZtlr8KAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 10 May 2014 16:02:48 -0000 + +On Sat, 10 May 2014, "W. Trevor King" wrote: +> On Thu, Apr 17, 2014 at 04:34:57PM -0400, Austin Clements wrote: +>> +$(DOCBUILDDIR)/.roff.stamp: ${MAN_RST_FILES} +>> ifeq ($(HAVE_SPHINX),1) +>> $(SPHINXBUILD) -b man $(ALLSPHINXOPTS) $(DOCBUILDDIR)/man +>> for section in 1 5 7; do \ +>> @@ -48,6 +54,7 @@ else +>> @echo "Fatal: build dependency fail." +>> @false +>> endif +>> + touch ${MAN_ROFF_FILES} $@ +> +> I'm poking around in the Makefile, and don't understand why we're +> touching ${MAN_ROFF_FILES} here. Either they were just created by +> Sphinx/rst2man, or we died with the @false. I doubt Sphinx or +> prerst2man.py are intelligent enough to not clobber the roff files if +> their content hasn't changed, but I don't see a point in explicitly +> bumping timestamps either. +> +> I think I'll drop the ${MAN_ROFF_FILES} as part of the patch I'm +> working on, but let me know if I'm just missing something. + +I think you're right. I can't reconstruct why I touched +${MAN_ROFF_FILES} here. Touching $@ obviously matters, but I think it +should be safe to drop the ${MAN_ROFF_FILES}. + +> Cheers, +> Trevor -- 2.26.2