From 7ae87ff7dccf8d9190cfd24951a7e335267cb512 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Fri, 3 Oct 2014 08:54:17 +0200 Subject: [PATCH] Re: [PATCH v2] VIM: Use notmuch CLI for config --- 0a/8ac37323a7c2f8d50368076a6000af4dc7a652 | 71 +++++++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 0a/8ac37323a7c2f8d50368076a6000af4dc7a652 diff --git a/0a/8ac37323a7c2f8d50368076a6000af4dc7a652 b/0a/8ac37323a7c2f8d50368076a6000af4dc7a652 new file mode 100644 index 000000000..2dcba6705 --- /dev/null +++ b/0a/8ac37323a7c2f8d50368076a6000af4dc7a652 @@ -0,0 +1,71 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6B1E0431FBD + for ; Thu, 2 Oct 2014 23:54:37 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9L+bbmb+K-pu for ; + Thu, 2 Oct 2014 23:54:30 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 4964D431FB6 + for ; Thu, 2 Oct 2014 23:54:30 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1XZwkz-0005NY-4C; Fri, 03 Oct 2014 03:54:25 -0300 +Received: (nullmailer pid 18600 invoked by uid 1000); Fri, 03 Oct 2014 + 06:54:17 -0000 +From: David Bremner +To: Ian Main , notmuch@notmuchmail.org +Subject: Re: [PATCH v2] VIM: Use notmuch CLI for config +In-Reply-To: <1412293635-31273-1-git-send-email-imain@stemwinder.org> +References: <1412286796-27479-1-git-send-email-imain@stemwinder.org> + <1412293635-31273-1-git-send-email-imain@stemwinder.org> +User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 03 Oct 2014 08:54:17 +0200 +Message-ID: <87r3ypr6cm.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 03 Oct 2014 06:54:37 -0000 + +Ian Main writes: + +> This patch switches from reading .notmuch-config directly to using +> the CLI the same way that emacs does it. It actually uses less code +> and is probably less error prone. +> +> Ian + +The general approach seems sane; it seems quite brittle to read the +config file directly. I notice there is not really any error handling; +OTOH, as far as I can read Ruby, there is not any in the previous +version either. Technically, this does add a dependency of the vim +client on the CLI that did not exist before. Personally I don't find +this onerous (even notmuch-vim users need "notmuch new", except in +rather unusual circumstances.). + +I'd like feedback/testing from actual vim interface users before +merging. + -- 2.26.2