From 7ad302e3145be50c0d6b61787c6b87f5c6fd70b9 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Fri, 24 Jan 2014 19:45:24 +2000 Subject: [PATCH] Re: [PATCH 1/2] emacs: defconst notmuch-emacs-version to a value during byte compilation --- 37/d4fd8227bbcd6a239187a74e48afea91bc2438 | 69 +++++++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 37/d4fd8227bbcd6a239187a74e48afea91bc2438 diff --git a/37/d4fd8227bbcd6a239187a74e48afea91bc2438 b/37/d4fd8227bbcd6a239187a74e48afea91bc2438 new file mode 100644 index 000000000..7a2dc1d56 --- /dev/null +++ b/37/d4fd8227bbcd6a239187a74e48afea91bc2438 @@ -0,0 +1,69 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 12050431FB6 + for ; Thu, 23 Jan 2014 15:45:40 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id l6kpqaxXvW7v for ; + Thu, 23 Jan 2014 15:45:35 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 5288F431FAF + for ; Thu, 23 Jan 2014 15:45:35 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1W6Txf-0000h8-Jv; Thu, 23 Jan 2014 19:45:27 -0400 +Received: (nullmailer pid 2894 invoked by uid 1000); Thu, 23 Jan 2014 + 23:45:24 -0000 +From: David Bremner +To: Mark Walters , Tomi Ollila + , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] emacs: defconst notmuch-emacs-version to a value + during byte compilation +In-Reply-To: <8738kezhwe.fsf@qmul.ac.uk> +References: <1390135903-28167-1-git-send-email-tomi.ollila@iki.fi> + <8738kezhwe.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.17+35~g3b36898 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 23 Jan 2014 19:45:24 -0400 +Message-ID: <874n4uqn3f.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 23 Jan 2014 23:45:40 -0000 + +Mark Walters writes: + +> If I make and then commit a small change to emacs/notmuch-tree.el and then +> remake then version string in the cli nor in emacs seems to be +> updated. If I make clean and then make it is updated. + +I think I understand why this is happening: notmuch-lib.el is not +recompiled if it isn't modified. I'm not sure of the best fix, but I +guess the dependencies in emacs/.eldeps need to be updated. One option +would be to have a seperate notmuch-version.el that depends on +everything. + +d + -- 2.26.2