From 7a4819529380828b5d89a639c23206548fc1dd24 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Sun, 17 Nov 2013 12:16:23 +1600 Subject: [PATCH] Re: fix for failing tests with gmime 2.6.19 --- 8b/9ca68837cac198ae249e240c8503a50022a82d | 130 ++++++++++++++++++++++ 1 file changed, 130 insertions(+) create mode 100644 8b/9ca68837cac198ae249e240c8503a50022a82d diff --git a/8b/9ca68837cac198ae249e240c8503a50022a82d b/8b/9ca68837cac198ae249e240c8503a50022a82d new file mode 100644 index 000000000..3a74e072a --- /dev/null +++ b/8b/9ca68837cac198ae249e240c8503a50022a82d @@ -0,0 +1,130 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 430A9429E32 + for ; Sat, 16 Nov 2013 12:16:36 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id AYfHC0HDtVna for ; + Sat, 16 Nov 2013 12:16:28 -0800 (PST) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 1D079429E30 + for ; Sat, 16 Nov 2013 12:16:28 -0800 (PST) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id 9C58D32802B; + Sat, 16 Nov 2013 12:16:27 -0800 (PST) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (unknown [198.129.209.202]) + (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id D2D3B2E50BFF; + Sat, 16 Nov 2013 12:16:26 -0800 (PST) +Received: by finestructure.net (Postfix, from userid 1000) + id 5E1EB60080; Sat, 16 Nov 2013 12:16:26 -0800 (PST) +From: Jameson Graef Rollins +To: David Bremner , + Daniel Kahn Gillmor , + notmuch +Subject: Re: fix for failing tests with gmime 2.6.19 +In-Reply-To: <87iovzvyui.fsf@zancas.localnet> +References: <1384100482-15453-1-git-send-email-david@tethera.net> + <52805350.70004@fifthhorseman.net> <87iovzywua.fsf@zancas.localnet> + <87iovzvyui.fsf@zancas.localnet> +User-Agent: Notmuch/0.16+120~gfd733a4 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 16 Nov 2013 12:16:23 -0800 +Message-ID: <87iovsxfu0.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 16 Nov 2013 20:16:36 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Mon, Nov 11 2013, David Bremner wrote: +> David Bremner writes: +> +>> Daniel Kahn Gillmor writes: +>> +>>> +>>> Please don't introduce this cruft into the notmuch codebase. It should +>>> be fixed in gmime, not worked-around notmuch. +>>> +>>> I've just uploaded gmime 2.6.19-2 to unstable to address this issue. +>>> +>> +>> Hi Daniel; +>> +>> Thanks a lot for that.=20 +>> +>> What I (still) wonder about is all the people not running Debian, in the +>> interval between the release of notmuch 0.17 and the next upstream +>> release of gmime (and propagation to various distros). Even on Debian, +>> building on testing and backports complicates things a bit. +> +> An alternative approach would be to fix=20 +> +> NOTMUCH_SKIP_TESTS=3D"reply reply-to-sender multipart.37 from-guessing" = +./notmuch-test +> +> to return exist status 0, and ideally to print the correct number of +> tests skipped. +> +> I think the former just requires patching line 85 of +> aggregate-results.sh. I don't see an easy way to do the latter. +> +> This is arguably less crufty, or at least uses existing cruft. On the +> other hand, it doesn't distinguish between a test printing an extra +> space, and complete garbage. + +I agree with Daniel that the original series adds a whole lot of +undesirable cruft to the test suite to get around one transient issue in +one of the notmuch dependencies. That doesn't seem like the best thing +to do imho. I would vote for this option instead, which doesn't modify +the test suite and just skips the affected tests until the new gmime +versions falls through everywhere. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.15 (GNU/Linux) + +iQIcBAEBCAAGBQJSh9KYAAoJEO00zqvie6q8UNsP/i6B5Q07UF6BXRW8BB6l+jQc +a9SISjPtQf2YEqw+DMPWJAl2/tR9SP5o8yfE1qs8pSGEAa4feMFGzo8lplAliexY +IOnQYSsH42gIEihrs+78FETRgp02kh3PLJ0/HfSrk8xjhTsSOMgyx9iSqHb70MGD +Rk7uZgJKWDASapv1l/6LK2WxcCiZe5WznT/Ryt3UUcgmczPz7KlnxrmkwvPT4vD+ +lUsTsmQslVtRC8GK7uZhAzuA0Ofc/pkTJSWogXMF5kU5EXw/RzNudM7lQ6/w0BzP +7l1jV0Xp+T77WdcGxSYEnm8PuugsHXjl80KemGES6dTANuvEd8bQJsnN3MqZHGlW +oDY5D6b5FDCBM/JJWmVgNIvqWhi7PnPZjPZ+w5Omt2bQXsetFKGxOntgO7UbA/DQ +me39jS8xrRaH6yVGdcQzCtJ+X9TgUc3NnXb9SJZhM33YqYDIFVgvXKazE2jACdNT +0i9V6HoLbm9fdPJgIana+4TSPv1ixM8Bf+0Uxj0uA0AIZ+Y3Tu+Yqq9EN6P8U1eF +p4lOgtDLo2K9ojq66BsXrN8FZ1VWQsN+hJyZDORyhFTucYEJQwA7P+kWIg+BKWp/ +Q4sPYN2cZLuLTiSTLc/PvImZmQ3r9shoavGyaQO+npkx/Jh8Tcbk/td3REIX7NvB +v2yFiJoml/aTzN3/q4mE +=Uc/t +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2