From 7a17fa90d033533c2d3861df1e20c1183554742e Mon Sep 17 00:00:00 2001 From: David Bremner Date: Thu, 13 Feb 2014 22:13:50 +2000 Subject: [PATCH] Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's locale --- 4b/e4149680b4ef109340efaa2335d5cfbeaf3433 | 83 +++++++++++++++++++++++ 1 file changed, 83 insertions(+) create mode 100644 4b/e4149680b4ef109340efaa2335d5cfbeaf3433 diff --git a/4b/e4149680b4ef109340efaa2335d5cfbeaf3433 b/4b/e4149680b4ef109340efaa2335d5cfbeaf3433 new file mode 100644 index 000000000..40690696d --- /dev/null +++ b/4b/e4149680b4ef109340efaa2335d5cfbeaf3433 @@ -0,0 +1,83 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 15B1B431FBD + for ; Wed, 12 Feb 2014 18:14:07 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 4nhMc51lptVF for ; + Wed, 12 Feb 2014 18:13:59 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E0A83431FAE + for ; Wed, 12 Feb 2014 18:13:58 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1WDloH-0004IE-HC; Wed, 12 Feb 2014 22:13:53 -0400 +Received: (nullmailer pid 27631 invoked by uid 1000); Thu, 13 Feb 2014 + 02:13:50 -0000 +From: David Bremner +To: "W. Trevor King" +Subject: Re: [PATCH v2 14/20] nmbug-status: Encode output using the user's + locale +In-Reply-To: <20140211223336.GM14197@odin.tremily.us> +References: + + <87eh396e6e.fsf@zancas.localnet> + <20140211201135.GJ14197@odin.tremily.us> + <8761ol5mvy.fsf@zancas.localnet> + <20140211223336.GM14197@odin.tremily.us> +User-Agent: Notmuch/0.17+53~g3e1d7f6 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 12 Feb 2014 22:13:50 -0400 +Message-ID: <877g8z4v4x.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +Cc: Tomi Ollila , notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 13 Feb 2014 02:14:07 -0000 + +"W. Trevor King" writes: +> +> I don't understand why your choice of LANG should depend on the +> interactive-ness of an invocation. + +It's not the choice of LANG, but rather the acceptability of crashing +with an unhandled exception. + +> The upside of a configurable language is that the user gets output in +> their preferred encoding (UTF-8 or not) and=E2=80=94with a bit of additio= +nal +> gettext work=E2=80=94in their preferred language. That sounds like a fair +> trade to me. + +The downside is that it introduces another error condition into the +script. The data from notmuch is unicode; conversion to most non-utf8 +locales is lossy and can cause crashes. That's why I don't like the +idea of enabling it without some explicit option or configuration +choice. + +d + +P.S. I just saw your other reply, and yeah, a rebased version of the +other 6 patches would be welcome. -- 2.26.2