From 79def43178dc60897b933e40a1ade5f622d47708 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Mon, 22 Sep 2014 11:54:52 +0200 Subject: [PATCH] [PATCH 01/11] lib: actually return failures from notmuch_message_tags_to_maildir_flags --- e8/ccdb360459f270e252f7bb081d49319037c15f | 92 +++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 e8/ccdb360459f270e252f7bb081d49319037c15f diff --git a/e8/ccdb360459f270e252f7bb081d49319037c15f b/e8/ccdb360459f270e252f7bb081d49319037c15f new file mode 100644 index 000000000..26ff2d27a --- /dev/null +++ b/e8/ccdb360459f270e252f7bb081d49319037c15f @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E527B431FDD + for ; Mon, 22 Sep 2014 02:54:57 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id bHXe8puv4m2O for ; + Mon, 22 Sep 2014 02:54:50 -0700 (PDT) +Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com + [209.85.212.177]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 0856F431FBC + for ; Mon, 22 Sep 2014 02:54:49 -0700 (PDT) +Received: by mail-wi0-f177.google.com with SMTP id q5so2606655wiv.4 + for ; Mon, 22 Sep 2014 02:54:48 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to + :references:in-reply-to:references; + bh=XIhOZBJgnqOmVPNAOevVVWG9yl/AJwcyVgfxbZ/aOik=; + b=FWux+zdfeMdAyWE9cio63erpwJCYaqUA9+eoPG2QFGYCw4hiRbtmlMdMdwFnYNEb1J + dnyj1Z97ie1IImaNxM92Q4tvQ507NUZYhh3ibe1hIcMHSfW7lY0Cu/WfRCj4QyPkgBVN + w+BrZRJrR+edmsvmk6+xngIsgp8qcxttHV/P6sryAg7rNnT1anzWNAn+vvWzYnzGLlyk + Etz5mEpucCnwwwWG8i/Kij9giGZDeE3lmpsFwzOYzsRe4c85+6w3xsW9GtNR3C33/39x + NCMc2o5UB/QIWvzru+WXmYbNKN86g3J/C+B1Zlu4T/B83QakHkeXmJu7Sv5tAV9lSLVH + 5V8Q== +X-Gm-Message-State: + ALoCoQl9Ru+LRj0JOcinrgyRdBIgRZOpuOlfURxiKkF0UkRnbCRWqKYXvbdb8K/NYGz6vi4+xW4m +X-Received: by 10.180.14.104 with SMTP id o8mr14298836wic.66.1411379688830; + Mon, 22 Sep 2014 02:54:48 -0700 (PDT) +Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3]) + by mx.google.com with ESMTPSA id + hi4sm11686042wjb.46.2014.09.22.02.54.48 for + (version=TLSv1.1 cipher=RC4-SHA bits=128/128); + Mon, 22 Sep 2014 02:54:48 -0700 (PDT) +From: Jani Nikula +To: notmuch@notmuchmail.org +Subject: [PATCH 01/11] lib: actually return failures from + notmuch_message_tags_to_maildir_flags +Date: Mon, 22 Sep 2014 11:54:52 +0200 +Message-Id: + <3edd34db5c4db9da9a3b0c46800126c24c334f39.1411379395.git.jani@nikula.org> +X-Mailer: git-send-email 1.7.2.5 +In-Reply-To: +References: +In-Reply-To: +References: +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 22 Sep 2014 09:54:58 -0000 + +The function takes great care to preserve the first error status it +encounters, yet fails to return that status to the caller. Fix it. +--- + lib/message.cc | 2 +- + 1 files changed, 1 insertions(+), 1 deletions(-) + +diff --git a/lib/message.cc b/lib/message.cc +index 68f7e68..7e82548 100644 +--- a/lib/message.cc ++++ b/lib/message.cc +@@ -1497,7 +1497,7 @@ notmuch_message_tags_to_maildir_flags (notmuch_message_t *message) + talloc_free (to_set); + talloc_free (to_clear); + +- return NOTMUCH_STATUS_SUCCESS; ++ return status; + } + + notmuch_status_t +-- +1.7.2.5 + -- 2.26.2