From 7941d1e35a088f1afbda6c7ef46c5c63d7367892 Mon Sep 17 00:00:00 2001 From: Christopher Wellons Date: Fri, 23 Aug 2013 22:11:37 +2000 Subject: [PATCH] Re: [PATCH] Switch to DEF from INITIAL-INPUT in completing-read. --- a8/e8bc57d40e3b78f51859ee88b9cf159ac24ed6 | 70 +++++++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 a8/e8bc57d40e3b78f51859ee88b9cf159ac24ed6 diff --git a/a8/e8bc57d40e3b78f51859ee88b9cf159ac24ed6 b/a8/e8bc57d40e3b78f51859ee88b9cf159ac24ed6 new file mode 100644 index 000000000..173194415 --- /dev/null +++ b/a8/e8bc57d40e3b78f51859ee88b9cf159ac24ed6 @@ -0,0 +1,70 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1E533431FC2 + for ; Thu, 22 Aug 2013 19:11:58 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id rnjsi5VbZEHp for ; + Thu, 22 Aug 2013 19:11:52 -0700 (PDT) +Received: from mail.nullprogram.com (mail.nullprogram.com [192.241.191.137]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 2156B431FAE + for ; Thu, 22 Aug 2013 19:11:52 -0700 (PDT) +Received: from localhost ([127.0.0.1] helo=susie.zeus.nullprogram.com) + by mail.nullprogram.com with esmtp (Exim 4.80) + (envelope-from ) + id 1VCgql-0003U3-Qi; Fri, 23 Aug 2013 02:11:47 +0000 +From: Christopher Wellons +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] Switch to DEF from INITIAL-INPUT in completing-read. +In-Reply-To: +References: <1377103488-7425-1-git-send-email-wellons@nullprogram.com> + + +User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 22 Aug 2013 22:11:37 -0400 +Message-ID: <87k3jdgnqe.fsf@susie.zeus.nullprogram.com> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 23 Aug 2013 02:11:58 -0000 + +Tomi Ollila writes: + +>> I agree that this behaves better, but the empty content with completing-read +>> looks a bit confusing (if arrow keys or tab aren't pressed) + +You're right. Taking a look at this with completing-read I see it's not +obvious what defaulting will do. + +> we could also drop the default/initial input: + +The default is usually what I want to select, so I like being able to +just hit tab/enter to select it. + +>> I don't know how ido-replaced completing-read (just ido-completing-read ?) +>> works there, though. + +I'm using ido-ubiquitous, which installs ido-completing-read overtop +completing-read along with some compatability tweaks. -- 2.26.2