From 78e98eaf5ee49bc6d62ef9bdf87066528bfba248 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Ren=C3=A9=20Scharfe?= Date: Sat, 17 Dec 2011 11:27:19 +0100 Subject: [PATCH] submodule: use diff_tree_combined_merge() instead of diff_tree_combined() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Use diff_tree_combined_merge() instead of open-coding it. Signed-off-by: René Scharfe Signed-off-by: Junio C Hamano --- submodule.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/submodule.c b/submodule.c index 788d5327a..9a2806067 100644 --- a/submodule.c +++ b/submodule.c @@ -371,23 +371,15 @@ static void collect_submodules_from_diff(struct diff_queue_struct *q, } -static void commit_need_pushing(struct commit *commit, struct commit_list *parent, int *needs_pushing) +static void commit_need_pushing(struct commit *commit, int *needs_pushing) { - struct sha1_array parents = SHA1_ARRAY_INIT; struct rev_info rev; - while (parent) { - sha1_array_append(&parents, parent->item->object.sha1); - parent = parent->next; - } - init_revisions(&rev, NULL); rev.diffopt.output_format |= DIFF_FORMAT_CALLBACK; rev.diffopt.format_callback = collect_submodules_from_diff; rev.diffopt.format_callback_data = needs_pushing; - diff_tree_combined(commit->object.sha1, &parents, 1, &rev); - - sha1_array_clear(&parents); + diff_tree_combined_merge(commit, 1, &rev); } int check_submodule_needs_pushing(unsigned char new_sha1[20], const char *remotes_name) @@ -410,7 +402,7 @@ int check_submodule_needs_pushing(unsigned char new_sha1[20], const char *remote die("revision walk setup failed"); while ((commit = get_revision(&rev)) && !needs_pushing) - commit_need_pushing(commit, commit->parents, &needs_pushing); + commit_need_pushing(commit, &needs_pushing); free(sha1_copy); strbuf_release(&remotes_arg); -- 2.26.2