From 780069e9d5a5a1b1b75eb9b73e588fe30dadddb9 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 3 Nov 2013 09:14:21 +2100 Subject: [PATCH] Re: [PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it --- cc/b644256c5f4187c49c245024a57aca9e6c33eb | 68 +++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 cc/b644256c5f4187c49c245024a57aca9e6c33eb diff --git a/cc/b644256c5f4187c49c245024a57aca9e6c33eb b/cc/b644256c5f4187c49c245024a57aca9e6c33eb new file mode 100644 index 000000000..bd323b694 --- /dev/null +++ b/cc/b644256c5f4187c49c245024a57aca9e6c33eb @@ -0,0 +1,68 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 45D46431FAF + for ; Sat, 2 Nov 2013 05:14:34 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id EeFjz6CQEpJy for ; + Sat, 2 Nov 2013 05:14:30 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 88D71431FAE + for ; Sat, 2 Nov 2013 05:14:30 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1Vca5w-0005hh-VR; Sat, 02 Nov 2013 09:14:24 -0300 +Received: (nullmailer pid 14761 invoked by uid 1000); Sat, 02 Nov 2013 + 12:14:21 -0000 +From: David Bremner +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH 3/6] lib: use the backup path provided by the user, don't + add anything to it +In-Reply-To: + <9ee3f2334a117b0a1b88650f44432423cbe95fd7.1383315568.git.jani@nikula.org> +References: + <9ee3f2334a117b0a1b88650f44432423cbe95fd7.1383315568.git.jani@nikula.org> +User-Agent: Notmuch/0.16+111~ga7964c8 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 02 Nov 2013 09:14:21 -0300 +Message-ID: <87li17rof6.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 02 Nov 2013 12:14:34 -0000 + +Jani Nikula writes: + +> Adding another level is just useless cruft. +> --- +> lib/database.cc | 14 ++++---------- +> notmuch-compact.c | 4 ++-- +> 2 files changed, 6 insertions(+), 12 deletions(-) + +The first two patches are fine, modulo my comments about documentation. +I think the backup path needs to be updated in notmuch-compact.c, and +possible the test updated (after applying +id:1383350515-24320-1-git-send-email-david@tethera.net) + +d -- 2.26.2