From 779f392d52cecd0989b65476568dd9753e410aad Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Tue, 20 Aug 2013 19:23:24 +0100 Subject: [PATCH] Re: [PATCH] emacs: add buttons for all multipart/related parts --- d5/0950ba5928df89838875f8da34a06b50f01418 | 129 ++++++++++++++++++++++ 1 file changed, 129 insertions(+) create mode 100644 d5/0950ba5928df89838875f8da34a06b50f01418 diff --git a/d5/0950ba5928df89838875f8da34a06b50f01418 b/d5/0950ba5928df89838875f8da34a06b50f01418 new file mode 100644 index 000000000..ce5639f8b --- /dev/null +++ b/d5/0950ba5928df89838875f8da34a06b50f01418 @@ -0,0 +1,129 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3E8BE431E62 + for ; Tue, 20 Aug 2013 11:23:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id g3YuI9UG8Qv8 for ; + Tue, 20 Aug 2013 11:23:40 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 2A293431FD6 + for ; Tue, 20 Aug 2013 11:23:39 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1VBqaT-0001uT-I2; Tue, 20 Aug 2013 19:23:28 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1VBqaT-0000CF-67; Tue, 20 Aug 2013 19:23:25 +0100 +From: Mark Walters +To: Jameson Graef Rollins , + Istvan Marko , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts +In-Reply-To: <87fvu4fl25.fsf@servo.finestructure.net> +References: + <87fvu4fl25.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Tue, 20 Aug 2013 19:23:24 +0100 +Message-ID: <87ob8ste5f.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 26e0a99910db8cbecbf5593e343a339b (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 20 Aug 2013 18:23:48 -0000 + + +Hi + +What does the (mis-behaving) part button say? is it [image/jpeg] or +[application/octet-stream as image/jpeg] or? and what do correctly +behaving part buttons say? + +Best wishes + +Mark + +Jameson Graef Rollins writes: + +> On Fri, Aug 16 2013, Istvan Marko wrote: +>> When text/html parts include images as multipart/related and the +>> text/plain alternative is used these images can be completely hidden +>> with no easy way to access them or even find out that they are there. +>> +>> Make notmuch-show-insert-part-multipart/related add buttons for all +>> parts, the first one visible the rest hidden. +> +> Hey, Istvan. Thanks so much for this patch. It seems to be addressing +> the same issue I reported in id:87ob8u8l6k.fsf@servo.finestructure.net. +> +> However, the behavior of the part button that now appears seems to be a +> bit strange. Clicking/hitting enter on the part attempts to save it +> rather than open it. I wouldn't be surprised if has nothing to do with +> the correctness of this patch, though. So is it possible that the +> button is not inserted in the most ideal way, or is there some other +> issue preventing it from behaving properly (could it have to do with the +> part being "inline"?)? +> +> jamie. +> +> +>> emacs/notmuch-show.el | 4 ++++ +>> 1 file changed, 4 insertions(+) +>> +>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +>> index 82b70ba..20844f0 100644 +>> --- a/emacs/notmuch-show.el +>> +++ b/emacs/notmuch-show.el +>> @@ -621,6 +621,10 @@ message at DEPTH in the current thread." +>> +>> ;; Render the primary part. +>> (notmuch-show-insert-bodypart msg (car inner-parts) depth) +>> + ;; Add hidden buttons for the rest +>> + (mapc (lambda (inner-part) +>> + (notmuch-show-insert-bodypart msg inner-part depth t)) +>> + (cdr inner-parts)) +>> +>> (when notmuch-show-indent-multipart +>> (indent-rigidly start (point) 1))) +>> -- +>> 1.8.1.4 +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2