From 76e804bfe2d984b5e0316326c859c56162f4ba44 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 12 Apr 2014 19:39:51 +0300 Subject: [PATCH] Re: [PATCH] nmbug: mark repository as bare on clone --- 2d/dbe343abd1126da22565f78e67ac314fc83256 | 96 +++++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 2d/dbe343abd1126da22565f78e67ac314fc83256 diff --git a/2d/dbe343abd1126da22565f78e67ac314fc83256 b/2d/dbe343abd1126da22565f78e67ac314fc83256 new file mode 100644 index 000000000..7643b4224 --- /dev/null +++ b/2d/dbe343abd1126da22565f78e67ac314fc83256 @@ -0,0 +1,96 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C69CA431FBD + for ; Sat, 12 Apr 2014 09:40:00 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 7bn8DlilQ4I8 for ; + Sat, 12 Apr 2014 09:39:56 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id DAF77431FBC + for ; Sat, 12 Apr 2014 09:39:55 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 72CB710008B; + Sat, 12 Apr 2014 19:39:51 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] nmbug: mark repository as bare on clone +In-Reply-To: <1397320232-32458-1-git-send-email-david@tethera.net> +References: <1397320232-32458-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.17+184~g85e3db6 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 12 Apr 2014 16:40:00 -0000 + +On Sat, Apr 12 2014, David Bremner wrote: + +> As far as I can figure out, if a git repository is non-bare, then it +> should either have core.worktree set, or the parent directory should +> be the worktree. Since the parent directory is usually the user's home +> directory, we don't want that. Although unlikely to be typed by +> mistake + +Based on that info change looks reasonable. I edited my ~/.nmbug/config +and changed bare = false -> bare = true and nothing borke so far. + +so +1 from me. + +Tomi + +> +> % cd $HOME && ln -s .nmbug .git && git reset --hard +> +> would delete a bunch of files. +> --- +> +> Hah, I managed to escalate a documentation quibble into a +> sortof-security issue. +> +> devel/nmbug/nmbug | 1 + +> 1 file changed, 1 insertion(+) +> +> diff --git a/devel/nmbug/nmbug b/devel/nmbug/nmbug +> index d6f5213..b18ded7 100755 +> --- a/devel/nmbug/nmbug +> +++ b/devel/nmbug/nmbug +> @@ -134,6 +134,7 @@ sub do_clone { +> $repository, $tempwork) == 0 +> or die "'git clone' exited with nonzero value\n"; +> git ('config', '--unset', 'core.worktree'); +> + git ('config', 'core.bare', 'true'); +> } +> +> sub is_committed { +> -- +> 1.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2