From 7633e1d9505bb117bd164e6d98fab0190724847c Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 24 Sep 2015 22:55:33 +0300 Subject: [PATCH] Re: [PATCH v2 6/9] cli: change the data structure for notmuch address deduplication --- 4f/982a2023e19440fb039d6cbbef13692c9c5e29 | 77 +++++++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 4f/982a2023e19440fb039d6cbbef13692c9c5e29 diff --git a/4f/982a2023e19440fb039d6cbbef13692c9c5e29 b/4f/982a2023e19440fb039d6cbbef13692c9c5e29 new file mode 100644 index 000000000..c30208bbc --- /dev/null +++ b/4f/982a2023e19440fb039d6cbbef13692c9c5e29 @@ -0,0 +1,77 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id DDB186DE1607 + for ; Thu, 24 Sep 2015 12:55:28 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.157 +X-Spam-Level: * +X-Spam-Status: No, score=1.157 tagged_above=-999 required=5 tests=[AWL=-0.239, + SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fml8ElfFTOdt for ; + Thu, 24 Sep 2015 12:55:27 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 133756DE0B64 + for ; Thu, 24 Sep 2015 12:55:27 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 9BACA10008D; + Thu, 24 Sep 2015 22:55:33 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , Jani Nikula , + notmuch@notmuchmail.org +Subject: Re: [PATCH v2 6/9] cli: change the data structure for notmuch address + deduplication +In-Reply-To: <87bncs2dov.fsf@zancas.localnet> +References: + + <87fv242e2a.fsf@zancas.localnet> <87bncs2dov.fsf@zancas.localnet> +User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 24 Sep 2015 19:55:29 -0000 + +On Thu, Sep 24 2015, David Bremner wrote: + +> David Bremner writes: +> +>> Jani Nikula writes: +>> +>> +>>> + else +>>> + v = !!m1->name - !!m2->name; +>> +>> Is this really idiomatic? It seems a little difficult to follow to me. +>> + +For me it took a while to grasp the meaning of that but after I spent +a minute looking at it it become clear to me. this part +1 + + +> Sorry, this stupid MUA I'm using confused me and I sent the reply +> halfway through reading the patch. Anyway, the rest looks OK. +> +> d + +Tomi -- 2.26.2